[Bug libc/17371] New: libc segfaults inside getifaddrs_internal

[Bug libc/17371] New: libc segfaults inside getifaddrs_internal

[simongmzlj at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17371

            Bug ID: 17371
           Summary: libc segfaults inside getifaddrs_internal
           Product: glibc
           Version: 2.20
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: simongmzlj at gmail dot com
                CC: drepper.fsp at gmail dot com

libc segfaults inside getifaddrs_internal. Noticed it in sudo and wireshark. A
quick backtrace produces this:

#0  0x00007faf8133fabc in getifaddrs_internal () from /usr/lib/libc.so.6
#1  0x00007faf8133fcc0 in getifaddrs () from /usr/lib/libc.so.6
#2  0x00007faf81c1534f in get_net_ifs (addrinfo=0x7fffa3b0de20) at
./net_ifs.c:124
#3  0x00007faf81c1672d in parse_args (argc=1, argv=0x7fffa3b0f128,
nargc=0x7fffa3b0df7c, nargv=0x7fffa3b0df70, settingsp=0x7fffa3b0df68,
env_addp=0x7fffa3b0df60) at ./parse_args.c:198
#4  0x00007faf81c19190 in main (argc=<optimized out>, argv=0x7fffa3b0f128,
envp=0x7fffa3b0f138) at ./sudo.c:191

I do have a an interesting network setup:

1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode
DEFAULT group default 
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: enp8s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast master
bridge0 state UP mode DEFAULT group default qlen 1000
    link/ether 74:d0:2b:c5:99:28 brd ff:ff:ff:ff:ff:ff
3: eno1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP
mode DEFAULT group default qlen 1000
    link/ether 74:d0:2b:c5:95:ef brd ff:ff:ff:ff:ff:ff
4: tap2: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast master
bridge0 state DOWN mode DEFAULT group default qlen 500
    link/ether a2:2e:cd:67:79:48 brd ff:ff:ff:ff:ff:ff
5: tap1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast master
bridge0 state UP mode DEFAULT group default qlen 500
    link/ether de:9c:71:d7:30:1b brd ff:ff:ff:ff:ff:ff
6: tap0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast master
bridge0 state DOWN mode DEFAULT group default qlen 500
    link/ether b6:ff:4a:7f:4e:4a brd ff:ff:ff:ff:ff:ff
7: bridge0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP
mode DEFAULT group default 
    link/ether c2:18:88:08:41:a6 brd ff:ff:ff:ff:ff:ff

Not sure what else exactly you need, feel free to ask.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17371] libc segfaults inside getifaddrs_internal

[simongmzlj at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17371

--- Comment #1 from Simon Gomizelj <simongmzlj at gmail dot com> ---
Created attachment 7777
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7777&action=edit
core file

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17371] libc segfaults inside getifaddrs_internal

[allan at archlinux dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17371

Allan McRae <allan at archlinux dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |allan at archlinux dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17371] libc segfaults inside getifaddrs_internal

[simongmzlj at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17371

--- Comment #3 from Simon Gomizelj <simongmzlj at gmail dot com> ---
Not sure if this is the correct fix, but this glibc for me. Looks like ipv6
parsing for certain devices was incorrect.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17371] libc segfaults inside getifaddrs_internal

[simongmzlj at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17371

--- Comment #2 from Simon Gomizelj <simongmzlj at gmail dot com> ---
Created attachment 7779
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7779&action=edit
patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17371] libc segfaults inside getifaddrs_internal

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17371

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  a7b872687073decdcc7effc2289877d69058aca9 (commit)
      from  61fe374a44a92621e0b75ec1f011ff1fba6c2148 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a7b872687073decdcc7effc2289877d69058aca9

commit a7b872687073decdcc7effc2289877d69058aca9
Author: Andreas Schwab <schwab@linux-m68k.org>
Date:   Sat Sep 13 10:10:29 2014 +0200

    Handle zero prefix length in getifaddrs (BZ #17371)

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                         |    6 ++++++
 NEWS                              |    2 +-
 sysdeps/unix/sysv/linux/ifaddrs.c |   11 ++++-------
 3 files changed, 11 insertions(+), 8 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17371] libc segfaults inside getifaddrs_internal

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17371

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.21

--- Comment #5 from Andreas Schwab <schwab@linux-m68k.org> ---
Fixed for 2.21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17371] libc segfaults inside getifaddrs_internal

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17371

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, release/2.20/master has been updated
       via  ea5509237291f1a109d46052353ece197f4213bc (commit)
       via  3b016908924afb5ef71ac874bedf8c6f0157941c (commit)
       via  b735a759ef35d73f1cfc783187fe8281b75069ac (commit)
      from  b8079dd0d360648e4e8de48656c5c38972621072 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ea5509237291f1a109d46052353ece197f4213bc

commit ea5509237291f1a109d46052353ece197f4213bc
Author: Andreas Schwab <schwab@linux-m68k.org>
Date:   Sat Sep 13 10:10:29 2014 +0200

    Handle zero prefix length in getifaddrs (BZ #17371)

    (cherry picked from commit a7b872687073decdcc7effc2289877d69058aca9)

    Conflicts:
        NEWS

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=3b016908924afb5ef71ac874bedf8c6f0157941c

commit 3b016908924afb5ef71ac874bedf8c6f0157941c
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri Sep 12 12:13:08 2014 +0000

    Add new Linux 3.16 constants to netinet/udp.h.

    This patch adds the new constants UDP_NO_CHECK6_TX and
    UDP_NO_CHECK6_RX from Linux 3.16 to sysdeps/gnu/netinet/udp.h.  (I
    believe the existing constants there are already Linux-specific,
    possibly with the intention that other OSes should adopt the same
    values if possible if adopting the features in question.)

    Tested on x86_64.

        * sysdeps/gnu/netinet/udp.h (UDP_NO_CHECK6_TX): New macro.
        (UDP_NO_CHECK6_RX): Likewise.

    (cherry picked from commit 0bd72468030947254e7de183cac1014dac884475)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b735a759ef35d73f1cfc783187fe8281b75069ac

commit b735a759ef35d73f1cfc783187fe8281b75069ac
Author: Allan McRae <allan@archlinux.org>
Date:   Sat Sep 13 15:41:54 2014 +1000

    Update Russian translation

    (cherry picked from commit d8f879ee3e4131542c2ac3d1d9db4cf12cb86729)

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                         |   15 +++++++++++++++
 NEWS                              |    6 ++++++
 po/ru.po                          |   10 +++++-----
 sysdeps/gnu/netinet/udp.h         |    4 ++++
 sysdeps/unix/sysv/linux/ifaddrs.c |   11 ++++-------
 5 files changed, 34 insertions(+), 12 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.