[Bug libc/18086] New: nice() sets errno to 0 on success

[Bug libc/18086] New: nice() sets errno to 0 on success

[jennieveenhuizen at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18086

            Bug ID: 18086
           Summary: nice() sets errno to 0 on success
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: minor
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: jennieveenhuizen at gmail dot com
                CC: drepper.fsp at gmail dot com

Created attachment 8176
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8176&action=edit
Diff against the current development source tree

The implementation of nice() sets errno to 0 on success.

Quoting POSIX: "No function in this volume of POSIX.1-2008 shall set errno to
0."

See attachment for the suggested fix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18086] nice() sets errno to 0 on success

[jennieveenhuizen at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18086

Jennie Veenhuizen <jennieveenhuizen at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8176|Diff against the current    |Suggested fix
        description|development source tree     |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18086] nice() sets errno to 0 on success

[jennieveenhuizen at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18086

Jennie Veenhuizen <jennieveenhuizen at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8176|Suggested fix               |Proposed patch
        description|                            |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18086] nice() sets errno to 0 on success

[jennieveenhuizen at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18086

--- Comment #1 from Jennie Veenhuizen <jennieveenhuizen at gmail dot com> ---
Created attachment 8181
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8181&action=edit
Test program

The bug is only triggered if the old nice value was not -1. I have attached a
small test program to demonstrate the problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18086] nice() sets errno to 0 on success

[ppluzhnikov at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18086

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppluzhnikov at google dot com
           Assignee|unassigned at sourceware dot org   |ppluzhnikov at google dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18086] nice() sets errno to 0 on success

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18086

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  84895dca70f972df3842fb88f7b33b5d695cc599 (commit)
      from  5011051da35a91577d262040791cbe5a868cffbd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=84895dca70f972df3842fb88f7b33b5d695cc599

commit 84895dca70f972df3842fb88f7b33b5d695cc599
Author: Paul Pluzhnikov <ppluzhnikov@google.com>
Date:   Tue Aug 11 23:40:00 2015 -0700

    Fix BZ #18086 -- nice resets errno to 0.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog            |    6 ++++++
 NEWS                 |    5 +++--
 posix/tst-nice.c     |   11 ++++++++++-
 sysdeps/posix/nice.c |    6 +++---
 4 files changed, 22 insertions(+), 6 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18086] nice() sets errno to 0 on success

[ppluzhnikov at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18086

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
Fixed on master.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18086] nice() sets errno to 0 on success

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18086

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.23

-- 
You are receiving this mail because:
You are on the CC list for the bug.