[Bug libc/18510] New: tilegx: strcasestr() does not handle non-ascii locales

[Bug libc/18510] New: tilegx: strcasestr() does not handle non-ascii locales

[cmetcalf at ezchip dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 6485 bytes --]

https://sourceware.org/bugzilla/show_bug.cgi?id=18510

            Bug ID: 18510
           Summary: tilegx: strcasestr() does not handle non-ascii locales
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: cmetcalf at ezchip dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

The vectorized strcasestr() for tilegx (sysdeps/tile/tilegx/strstr.c) does
lowercasing 8 characters at a time with vector operations, creating a mask of
whether the characters are in the range 'A'..'Z', and then subtracting 32 for
each character in that range.  This is correct for ASCII-cased locales but not
for non-ascii case locales.  It's straightforward to know if we're in such a
locale or not:

  __locale_t loc = _NL_CURRENT_LOCALE;
  struct __locale_data *ctype = loc->__locales[LC_CTYPE];
  int nonascii = ctype->values[_NL_ITEM_INDEX(_NL_CTYPE_NONASCII_CASE)].word

but it is less clear whether the word-at-a-time infrastructure remains faster
if we have do eight tolower() function calls per word read, since the time
taken to do conversions on characters past the end of the string will penalize
the overall performance of this routine.  For reasonably-sized strings that
approach will still be faster.  However, defer this for now since Ondřej Bílka
is working on a more general framework.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
>From glibc-bugs-return-28475-listarch-glibc-bugs=sources.redhat.com@sourceware.org Tue Jun 09 19:52:58 2015
Return-Path: <glibc-bugs-return-28475-listarch-glibc-bugs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-glibc-bugs@sources.redhat.com
Received: (qmail 85764 invoked by alias); 9 Jun 2015 19:52:58 -0000
Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <glibc-bugs.sourceware.org>
List-Subscribe: <mailto:glibc-bugs-subscribe@sourceware.org>
List-Post: <mailto:glibc-bugs@sourceware.org>
List-Help: <mailto:glibc-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: glibc-bugs-owner@sourceware.org
Delivered-To: mailing list glibc-bugs@sourceware.org
Received: (qmail 85713 invoked by uid 55); 9 Jun 2015 19:52:54 -0000
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/18507] [wordsize-64] pathconf statvfs namespace
Date: Tue, 09 Jun 2015 19:52:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: libc
X-Bugzilla-Version: 2.21
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-18507-131-WI4DyXWdwD@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-18507-131@http.sourceware.org/bugzilla/>
References: <bug-18507-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg00086.txt.bz2
Content-length: 2889

https://sourceware.org/bugzilla/show_bug.cgi?id\x18507

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  d3ab671c942ba15a5b20f383ce71e387f17ae2c4 (commit)
      from  dd26c44403582fdf10d663170f947dfe4b3207a0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;hÓab671c942ba15a5b20f383ce71e387f17ae2c4

commit d3ab671c942ba15a5b20f383ce71e387f17ae2c4
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Tue Jun 9 19:52:01 2015 +0000

    Fix pathconf statvfs namespace (bug 18507).

    pathconf uses __statvfs64, and fpathconf uses __fstatvfs64.  On
    systems using sysdeps/unix/sysv/linux/wordsize-64, __statvfs64 then
    brings in the strong symbol statvfs, and __fstatvfs64 brings in the
    strong symbol fstatvfs, which are not in all the standards that have
    pathconf and fpathconf.  This patch fixes this by making those symbols
    into weak aliases.

    Tested for x86_64 and x86 (testsuite, and that disassembly of
    installed shared libraries is unchanged by the patch).

        [BZ #18507]
        * sysdeps/unix/sysv/linux/fstatvfs.c (fstatvfs): Rename to
        __fstatvfs and define as weak alias of __fstatvfs.  Use
        libc_hidden_weak.
        * sysdeps/unix/sysv/linux/statvfs.c (statvs): Rename to __statvfs
        and define as weak alias of __statvfs.  Use libc_hidden_weak.
        * sysdeps/unix/sysv/linux/wordsize-64/fstatvfs.c (__fstatvfs64):
        Define as alias of __fstatvfs, not fstatvfs.
        (fstatvfs64): Likewise.
        * sysdeps/unix/sysv/linux/wordsize-64/statvfs.c (__statvfs64):
        Define as alias of __statvfs, not statvfs.
        (statvfs64): Likewise.
        * conform/Makefile (test-xfail-POSIX/unistd.h/linknamespace):
        Remove variable.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                      |   17 +++++++++++++++++
 NEWS                                           |    2 +-
 conform/Makefile                               |    1 -
 sysdeps/unix/sysv/linux/fstatvfs.c             |    5 +++--
 sysdeps/unix/sysv/linux/statvfs.c              |    5 +++--
 sysdeps/unix/sysv/linux/wordsize-64/fstatvfs.c |    4 ++--
 sysdeps/unix/sysv/linux/wordsize-64/statvfs.c  |    4 ++--
 7 files changed, 28 insertions(+), 10 deletions(-)

--
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/18510] tilegx: strcasestr() does not handle non-ascii locales

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18510

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libc                        |locale

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/18510] tilegx: strcasestr() does not handle non-ascii locales

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18510

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg
             Status|NEW                         |RESOLVED

--- Comment #1 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
Tile architecture support has been removed from glibc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.