public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/18822] Internal functions are called via PLT
  2015-08-13 20:06 [Bug libc/18822] New: Internal functions are called via PLT hjl.tools at gmail dot com
@ 2015-08-13 20:06 ` hjl.tools at gmail dot com
  2015-08-13 20:35 ` joseph at codesourcery dot com
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: hjl.tools at gmail dot com @ 2015-08-13 20:06 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=18822

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |2.22

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libc/18822] New: Internal functions are called via PLT
@ 2015-08-13 20:06 hjl.tools at gmail dot com
  2015-08-13 20:06 ` [Bug libc/18822] " hjl.tools at gmail dot com
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: hjl.tools at gmail dot com @ 2015-08-13 20:06 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=18822

            Bug ID: 18822
           Summary: Internal functions are called via PLT
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

The following internal functions are called via PLT on x86:

__access
__add_to_environ
__alloc_dir
__argp_error
__argp_failure
__argp_fmtstream_ensur
__argp_fmtstream_free
__argp_fmtstream_print
__argp_fmtstream_updat
__argp_fmtstream_write
__argp_input
__argp_make_fmtstream
__argp_state_help
__argz_add
__argz_add_sep
__argz_append
__argz_create_sep
__asctime_r
__assert_fail_base
__brk
__bsd_getpt
__btowc
__chdir
__chmod
__clearenv
__closedir
__collidx_table_lookup
__collseq_table_lookup
__dcigettext
__dcngettext
__divdi3_internal
__drand48_iterate
__dup
__ecvt_r
__endutent
__erand48_r
__execve
__execvpe
__fchdir
__fcloseall
__fcvt_r
__fdopendir
__fgetgrent_r
__fgetpwent_r
__fgetsgent_r
__fgetspent_r
__flockfile
__fopen_internal
__fopen_maybe_mmap
__fstatfs
__fstatfs64
__fstatvfs64
__ftruncate
__ftruncate64
__funlockfile
__fwprintf
__fxprintf
__gconv
__gconv_close
__gconv_close_transfor
__gconv_compare_alias
__gconv_compare_alias_
__gconv_find_shlib
__gconv_find_transform
__gconv_get_builtin_tr
__gconv_get_path
__gconv_load_cache
__gconv_lookup_cache
__gconv_open
__gconv_release_cache
__gconv_release_shlib
__gconv_release_step
__gen_tempname
__getaliasbyname_r
__get_avphys_pages
__get_child_max
__getclktck
__getcwd
__getdate_r
__getdents
__getdents64
__getdtablesize
__getegid
__geteuid
__getgid
__getgrgid_r
__getgrnam_r
__getgroups
__gethostbyaddr_r
__gethostbyname2_r
__gethostbyname_r
__gethostname
__getline
__getnetbyaddr_r
__getnetbyname_r
__getnetgrent_r
__get_nprocs
__get_nprocs_conf
__get_phys_pages
__getprotobyname_r
__getprotobynumber_r
__getpwnam_r
__getpwuid_r
__getrpcbyname_r
__getrpcbynumber_r
__getservbyname_r
__getservbyport_r
__getsgnam_r
__get_sol
__getspnam_r
__gettext_extract_plur
__gettext_free_exp
__gettextparse
__getuid
__getutent
__getutent_r
__getutid
__getutid_r
__getutline
__getutline_r
__glob64
__group_member
__guess_grouping
__hash_string
__hasmntopt
__idna_to_ascii_lz
__idna_to_unicode_lzlz
__ifreq
__init_misc
__initstate_r
__internal_statvfs
__internal_statvfs64
__ioctl
__isatty
__jrand48_r
__kill
__lcong48_r
__libc_message
__libc_pread64
__libc_print_version
__longjmp
____longjmp_chk
__lseek64
__malloc_check_init
__mbsnrtowcs
__mbsrtowcs
__memcpy_g_internal
__memrchr
__mkdir
__mktime_internal
__mmap
__mmap64
__moddi3_internal
__moncontrol
__mpn_add_1
__mpn_addmul_1
__mpn_add_n
__mpn_cmp
__mpn_construct_double
__mpn_construct_float
__mpn_construct_long_d
__mpn_divrem
__mpn_extract_double
__mpn_extract_long_dou
__mpn_impn_mul_n
__mpn_impn_mul_n_basec
__mpn_impn_sqr_n
__mpn_impn_sqr_n_basec
__mpn_lshift
__mpn_mul
__mpn_mul_1
__mpn_rshift
__mpn_sub_1
__mpn_submul_1
__mpn_sub_n
__mprotect
__mremap
__munmap
__netlink_close
__netlink_free_handle
__netlink_open
__netlink_request
__new_exitfn
__new_getrlimit
__nis_hash
__nrand48_r
__nscd_cache_search
__nscd_getai
__nscd_getgrgid_r
__nscd_getgrnam_r
__nscd_getgrouplist
__nscd_gethostbyaddr_r
__nscd_gethostbyname2_
__nscd_gethostbyname_r
__nscd_get_map_ref
__nscd_get_nl_timestam
__nscd_getpwnam_r
__nscd_getpwuid_r
__nscd_getservbyname_r
__nscd_getservbyport_r
__nscd_innetgr
__nscd_setnetgrent
__nscd_unmap
__nss_endent
__nss_ethers_lookup
__nss_getent
__nss_getent_r
__nss_netgroup_lookup
__nss_publickey_lookup
__nss_setent
__offtime
__old_getdents64
__old_glob64
__old_readdir64
__opendir
__opendirat
__path_search
__pipe2
__posix_fallocate64_l6
__posix_openpt
__posix_spawn_file_act
__pread
__printf_fphex
__profil
__pthread_unwind
__ptsname_internal
__ptsname_r
__pututline
__pwrite
__qecvt_r
__qfcvt_r
__random
__random_r
__readdir
__readdir64
__readlink
__readv
__realpath
__re_compile_fastmap
__regcomp
__regexec
__regfree
__register_printf_spec
__res_vinit
__rmdir
__rpc_thread_clnt_clea
__rpc_thread_key_clean
__rpc_thread_svc_clean
__rpc_thread_variables
__scalbn
__scalbnf
__scalbnl
__sched_getaffinity_ne
__sched_setaffinity_ne
__sched_setparam
__seed48_r
__setcontext
__setenv
__setfpucw
__setrlimit
__setsid
__setstate_r
__setutent
__sgetsgent_r
__sgetspent_r
__sigaltstack
__sigblock
__sigprocmask
__sigsetmask
__sleep
__snprintf
__spawni
__srand48_r
__srandom_r
__statfs64
__statfs_chown_restric
__statfs_filesize_max
__statfs_link_max
__statfs_symlinks
__statvfs64
__statvfs_getflags
__strchr_g_internal
__strchrnul
__strcspn_ia32
__strdiff
__strncasecmp
__strpbrk_ia32
__strptime_internal
__strspn_ia32
__tcgetattr
__tdestroy
__ttyname_r
__tz_compute
__tz_convert
__tzfile_compute
__tzfile_default
__tzfile_read
__tzname_max
__tzset
__tzset_parse_tz
__tzstring
__udivdi3_internal
__umoddi3_internal
__unlink
__unsetenv
__updwtmp
__utmpname
__vfwprintf
__vfwscanf
__vstrfmon_l
__vswprintf
__wcpncpy
__wcrtomb
__wcscat
__wcschrnul
__wcsdiff
__wcslen
__wcsmbs_clone_conv
__wcsmbs_load_conv
__wcsmbs_named_conv
__wcsncpy
__wcsnlen
__wcsnrtombs
__wcsrtombs
____wcstod_l_internal
____wcstof_l_internal
____wcstold_l_internal
____wcstol_l_internal
____wcstoll_l_internal
____wcstoul_l_internal
____wcstoull_l_interna
__wctrans
__wctype
__wmemcpy
__wmemmove
__wmempcpy
__writev
__xstat32_conv

Most, if not all, of them should be called via hidden target.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libc/18822] Internal functions are called via PLT
  2015-08-13 20:06 [Bug libc/18822] New: Internal functions are called via PLT hjl.tools at gmail dot com
  2015-08-13 20:06 ` [Bug libc/18822] " hjl.tools at gmail dot com
@ 2015-08-13 20:35 ` joseph at codesourcery dot com
  2015-08-14  0:20 ` hjl.tools at gmail dot com
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: joseph at codesourcery dot com @ 2015-08-13 20:35 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=18822

--- Comment #1 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
Could you post your tools for identifying such calls?  I agree we should 
bypass the PLT for internal calls (except when needed, in particular for 
IFUNCs), but think we'll need a test in the testsuite to avoid regressing 
in this regard.  Whatever the tool is, it appears to have truncated long 
function names.

Remember when adding hidden aliases to ensure that attributes on the 
original declaration are also applied to the alias (e.g. __THROW) to avoid 
pessimizing code generation in other ways.  That's another thing that's 
error-prone to do manually but I don't know how to add a test to the 
testsuite that internal function aliases get the same attributes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libc/18822] Internal functions are called via PLT
  2015-08-13 20:06 [Bug libc/18822] New: Internal functions are called via PLT hjl.tools at gmail dot com
  2015-08-13 20:06 ` [Bug libc/18822] " hjl.tools at gmail dot com
  2015-08-13 20:35 ` joseph at codesourcery dot com
@ 2015-08-14  0:20 ` hjl.tools at gmail dot com
  2015-08-14  1:14 ` jsweval at arxan dot com
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: hjl.tools at gmail dot com @ 2015-08-14  0:20 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=18822

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to joseph@codesourcery.com from comment #1)
> Could you post your tools for identifying such calls?  I agree we should 

On x86:

readelf -rw libc_pic.a | grep "  __" | grep R_386_PLT32 | grep -v __GI | awk '{
print $5 }' | sort | uniq

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libc/18822] Internal functions are called via PLT
  2015-08-13 20:06 [Bug libc/18822] New: Internal functions are called via PLT hjl.tools at gmail dot com
                   ` (2 preceding siblings ...)
  2015-08-14  0:20 ` hjl.tools at gmail dot com
@ 2015-08-14  1:14 ` jsweval at arxan dot com
  2015-08-14 10:04 ` fweimer at redhat dot com
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: jsweval at arxan dot com @ 2015-08-14  1:14 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=18822

Jevin Sweval <jsweval at arxan dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsweval at arxan dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libc/18822] Internal functions are called via PLT
  2015-08-13 20:06 [Bug libc/18822] New: Internal functions are called via PLT hjl.tools at gmail dot com
                   ` (3 preceding siblings ...)
  2015-08-14  1:14 ` jsweval at arxan dot com
@ 2015-08-14 10:04 ` fweimer at redhat dot com
  2015-08-19 11:47 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: fweimer at redhat dot com @ 2015-08-14 10:04 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=18822

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libc/18822] Internal functions are called via PLT
  2015-08-13 20:06 [Bug libc/18822] New: Internal functions are called via PLT hjl.tools at gmail dot com
                   ` (4 preceding siblings ...)
  2015-08-14 10:04 ` fweimer at redhat dot com
@ 2015-08-19 11:47 ` cvs-commit at gcc dot gnu.org
  2015-10-14 12:57 ` fweimer at redhat dot com
  2015-10-14 13:49 ` cvs-commit at gcc dot gnu.org
  7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-08-19 11:47 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=18822

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  33c898d1607c1b8dac69c76eec289980292ebfc2 (commit)
       via  7e58ab243de4a89c49eec1521970c2a05c9e4adc (commit)
      from  3552daa7ac08c8dd2fc59393fc57e0b4e7aec94e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=33c898d1607c1b8dac69c76eec289980292ebfc2

commit 33c898d1607c1b8dac69c76eec289980292ebfc2
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Aug 19 04:40:35 2015 -0700

    Mark __xstatXX_conv as hidden

    __xstat_conv, __xstat64_conv and __xstat32_conv are internal to glibc.
    They should be marked as hidden so that they can't be called without
    PLT.

        [BZ #18822]
        * sysdeps/unix/sysv/linux/xstatconv.h (__xstat_conv): Add
        attribute_hidden.
        (__xstat64_conv): Likewise.
        (__xstat32_conv): Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7e58ab243de4a89c49eec1521970c2a05c9e4adc

commit 7e58ab243de4a89c49eec1521970c2a05c9e4adc
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Aug 19 04:39:47 2015 -0700

    Call __setcontext with HIDDEN_JUMPTARGET

    i386 __makecontext should call __setcontext with HIDDEN_JUMPTARGET.

        [BZ #18822]
        * sysdeps/unix/sysv/linux/i386/makecontext.S (__makecontext):
        Don't load %ebx when calling __setcontext.  Call __setcontext
        with HIDDEN_JUMPTARGET.
        * sysdeps/unix/sysv/linux/i386/setcontext.S (__setcontext): Add
        libc_hidden_def.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                  |   17 +++++++++++++++++
 sysdeps/unix/sysv/linux/i386/makecontext.S |    7 +------
 sysdeps/unix/sysv/linux/i386/setcontext.S  |    1 +
 sysdeps/unix/sysv/linux/xstatconv.h        |    9 ++++++---
 4 files changed, 25 insertions(+), 9 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libc/18822] Internal functions are called via PLT
  2015-08-13 20:06 [Bug libc/18822] New: Internal functions are called via PLT hjl.tools at gmail dot com
                   ` (5 preceding siblings ...)
  2015-08-19 11:47 ` cvs-commit at gcc dot gnu.org
@ 2015-10-14 12:57 ` fweimer at redhat dot com
  2015-10-14 13:49 ` cvs-commit at gcc dot gnu.org
  7 siblings, 0 replies; 9+ messages in thread
From: fweimer at redhat dot com @ 2015-10-14 12:57 UTC (permalink / raw)
  To: glibc-bugs

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 9703 bytes --]

https://sourceware.org/bugzilla/show_bug.cgi?id=18822

--- Comment #8 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to H.J. Lu from comment #2)
> (In reply to joseph@codesourcery.com from comment #1)
> > Could you post your tools for identifying such calls?  I agree we should 
> 
> On x86:
> 
> readelf -rw libc_pic.a | grep "  __" | grep R_386_PLT32 | grep -v __GI | awk
> '{ print $5 }' | sort | uniq

Please use “readelf -rwW”, it avoids truncating the symbols.

Do these instances not show up in libc.so.6 because the linker optimizes them
to direct calls due to their symbol visibility?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
>From glibc-bugs-return-30144-listarch-glibc-bugs=sources.redhat.com@sourceware.org Wed Oct 14 13:30:26 2015
Return-Path: <glibc-bugs-return-30144-listarch-glibc-bugs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-glibc-bugs@sources.redhat.com
Received: (qmail 125555 invoked by alias); 14 Oct 2015 13:30:25 -0000
Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <glibc-bugs.sourceware.org>
List-Subscribe: <mailto:glibc-bugs-subscribe@sourceware.org>
List-Post: <mailto:glibc-bugs@sourceware.org>
List-Help: <mailto:glibc-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: glibc-bugs-owner@sourceware.org
Delivered-To: mailing list glibc-bugs@sourceware.org
Received: (qmail 125415 invoked by uid 48); 14 Oct 2015 13:30:12 -0000
From: "hjl.tools at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/18822] Internal functions are called via PLT
Date: Wed, 14 Oct 2015 13:30:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: libc
X-Bugzilla-Version: 2.22
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hjl.tools at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: security-
X-Bugzilla-Changed-Fields:
Message-ID: <bug-18822-131-TVoPVTL7gF@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-18822-131@http.sourceware.org/bugzilla/>
References: <bug-18822-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg00181.txt.bz2
Content-length: 2860

https://sourceware.org/bugzilla/show_bug.cgi?id=18822

--- Comment #9 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Florian Weimer from comment #8)
> (In reply to H.J. Lu from comment #2)
> > (In reply to joseph@codesourcery.com from comment #1)
> > > Could you post your tools for identifying such calls?  I agree we should 
> > 
> > On x86:
> > 
> > readelf -rw libc_pic.a | grep "  __" | grep R_386_PLT32 | grep -v __GI | awk
> > '{ print $5 }' | sort | uniq
> 
> Please use “readelf -rwW”, it avoids truncating the symbols.

It was a typo.  It should be

readelf -rW libc_pic.a | grep "  __" | grep R_386_PLT32 | grep -v __GI | awk '{
print $5 }' | sort | uniq

> Do these instances not show up in libc.so.6 because the linker optimizes
> them to direct calls due to their symbol visibility?

Yes, and GCC generates different codes with hidden visibility:

[hjl@gnu-tools-1 pr67220]$ cat x.i
extern void *foo1(void);
extern void *foo2(void) __attribute__ ((visibility ("hidden")));

void
bar1 (void)
{
  foo1 ();
}

void
bar2 (void)
{
  foo2 ();
}
[hjl@gnu-tools-1 pr67220]$ gcc -S -O2 -fPIC x.i -m32  
[hjl@gnu-tools-1 pr67220]$ cat x.s
        .file   "x.i"
        .section        .text.unlikely,"ax",@progbits
.LCOLDB0:
        .text
.LHOTB0:
        .p2align 4,,15
        .globl  bar1
        .type   bar1, @function
bar1:
.LFB0:
        .cfi_startproc
        pushl   %ebx
        .cfi_def_cfa_offset 8
        .cfi_offset 3, -8
        call    __x86.get_pc_thunk.bx
        addl    $_GLOBAL_OFFSET_TABLE_, %ebx
        subl    $8, %esp
        .cfi_def_cfa_offset 16
        call    foo1@PLT
        addl    $8, %esp
        .cfi_def_cfa_offset 8
        popl    %ebx
        .cfi_restore 3
        .cfi_def_cfa_offset 4
        ret
        .cfi_endproc
.LFE0:
        .size   bar1, .-bar1
        .section        .text.unlikely
.LCOLDE0:
        .text
.LHOTE0:
        .section        .text.unlikely
.LCOLDB1:
        .text
.LHOTB1:
        .p2align 4,,15
        .globl  bar2
        .type   bar2, @function
bar2:
.LFB1:
        .cfi_startproc
        jmp     foo2
        .cfi_endproc
.LFE1:
        .size   bar2, .-bar2
        .section        .text.unlikely
.LCOLDE1:
        .text
.LHOTE1:
        .section       
.text.__x86.get_pc_thunk.bx,"axG",@progbits,__x86.get_pc_thunk.bx,comdat
        .globl  __x86.get_pc_thunk.bx
        .hidden __x86.get_pc_thunk.bx
        .type   __x86.get_pc_thunk.bx, @function
__x86.get_pc_thunk.bx:
.LFB2:
        .cfi_startproc
        movl    (%esp), %ebx
        ret
        .cfi_endproc
.LFE2:
        .hidden foo2
        .ident  "GCC: (GNU) 5.2.1 20150929 (Red Hat 5.2.1-3)"
        .section        .note.GNU-stack,"",@progbits
[hjl@gnu-tools-1 pr67220]$

-- 
You are receiving this mail because:
You are on the CC list for the bug.
>From glibc-bugs-return-30145-listarch-glibc-bugs=sources.redhat.com@sourceware.org Wed Oct 14 13:32:49 2015
Return-Path: <glibc-bugs-return-30145-listarch-glibc-bugs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-glibc-bugs@sources.redhat.com
Received: (qmail 1086 invoked by alias); 14 Oct 2015 13:32:49 -0000
Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <glibc-bugs.sourceware.org>
List-Subscribe: <mailto:glibc-bugs-subscribe@sourceware.org>
List-Post: <mailto:glibc-bugs@sourceware.org>
List-Help: <mailto:glibc-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: glibc-bugs-owner@sourceware.org
Delivered-To: mailing list glibc-bugs@sourceware.org
Received: (qmail 1003 invoked by uid 55); 14 Oct 2015 13:32:45 -0000
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/19007] FAIL: elf/check-localplt with -z now and binutils 2.26
Date: Wed, 14 Oct 2015 13:32:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: libc
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: security-
X-Bugzilla-Changed-Fields:
Message-ID: <bug-19007-131-JlWdNOkQ2F@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-19007-131@http.sourceware.org/bugzilla/>
References: <bug-19007-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg00182.txt.bz2
Content-length: 2107

https://sourceware.org/bugzilla/show_bug.cgi?id\x19007

--- Comment #13 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  d3d9c95aefded7716d037e241f9d23a1cccab45a (commit)
      from  8f763b04a0249d5a94a667da31294dd2395ec3bf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;hÓd9c95aefded7716d037e241f9d23a1cccab45a

commit d3d9c95aefded7716d037e241f9d23a1cccab45a
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Oct 14 05:59:50 2015 -0700

    Support PLT and GOT references in local PIC check

    Linker in binutils 2.26 and newer generate GOT references instead
    PLT references when -z now is passed to linker.  We need to extend
    scripts/localplt.awk to allow PLT or GOT references.

        [BZ #19007]
        * scripts/localplt.awk: Also allow GOT references.
        * sysdeps/unix/sysv/linux/i386/localplt.data: Mark
        _Unwind_Find_FDE, calloc, memalign, realloc and __libc_memalign
        with "+ REL R_386_GLOB_DAT".
        * sysdeps/x86_64/localplt.data: Mark calloc, memalign, realloc
        and __libc_memalign with "+ RELA R_X86_64_GLOB_DAT".

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                  |   10 ++++++++++
 NEWS                                       |    6 +++---
 scripts/localplt.awk                       |    2 +-
 sysdeps/unix/sysv/linux/i386/localplt.data |   16 ++++++++--------
 sysdeps/x86_64/localplt.data               |   14 +++++++-------
 5 files changed, 29 insertions(+), 19 deletions(-)

--
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libc/18822] Internal functions are called via PLT
  2015-08-13 20:06 [Bug libc/18822] New: Internal functions are called via PLT hjl.tools at gmail dot com
                   ` (6 preceding siblings ...)
  2015-10-14 12:57 ` fweimer at redhat dot com
@ 2015-10-14 13:49 ` cvs-commit at gcc dot gnu.org
  7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-10-14 13:49 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=18822

--- Comment #10 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  d95453ef5d9fccac44ab3d4a161d917e7ef6231f (commit)
      from  d3d9c95aefded7716d037e241f9d23a1cccab45a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d95453ef5d9fccac44ab3d4a161d917e7ef6231f

commit d95453ef5d9fccac44ab3d4a161d917e7ef6231f
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Oct 14 06:33:24 2015 -0700

    Avoid PLT when calling __sched_getaffinity_new

    This patch adds an internal entry for __sched_getaffinity_new so that
    __sched_getaffinity_old calls __sched_getaffinity_new without going
    through PLT.

        [BZ #18822]
        * sysdeps/unix/sysv/linux/sched_getaffinity.c
        (__sched_getaffinity_new): Add libc_hidden_proto and
        libc_hidden_def.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                   |    7 +++++++
 sysdeps/unix/sysv/linux/sched_getaffinity.c |    7 +++++++
 2 files changed, 14 insertions(+), 0 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2015-10-14 13:49 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-13 20:06 [Bug libc/18822] New: Internal functions are called via PLT hjl.tools at gmail dot com
2015-08-13 20:06 ` [Bug libc/18822] " hjl.tools at gmail dot com
2015-08-13 20:35 ` joseph at codesourcery dot com
2015-08-14  0:20 ` hjl.tools at gmail dot com
2015-08-14  1:14 ` jsweval at arxan dot com
2015-08-14 10:04 ` fweimer at redhat dot com
2015-08-19 11:47 ` cvs-commit at gcc dot gnu.org
2015-10-14 12:57 ` fweimer at redhat dot com
2015-10-14 13:49 ` cvs-commit at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).