[Bug stdio/18872] New: Fix memory leak in printf_positional

[Bug stdio/18872] New: Fix memory leak in printf_positional

[eggert at gnu dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18872

            Bug ID: 18872
           Summary: Fix memory leak in printf_positional
           Product: glibc
           Version: 2.22
            Status: NEW
          Severity: normal
          Priority: P2
         Component: stdio
          Assignee: unassigned at sourceware dot org
          Reporter: eggert at gnu dot org
  Target Milestone: ---

Created attachment 8553
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8553&action=edit
Fix memory leak in printf_positional

A Coverity scan found a memory leak in the printf_positional code introduced in
glibc 2.22.  Proposed patch attached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/18872] Fix memory leak in printf_positional

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18872

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/18872] Fix memory leak in printf_positional

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18872

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlos at redhat dot com

--- Comment #1 from Carlos O'Donell <carlos at redhat dot com> ---
This looks good to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/18872] Fix memory leak in printf_positional

[joseph at codesourcery dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18872

--- Comment #2 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
But as I noted in 
<https://sourceware.org/ml/libc-alpha/2015-08/msg01096.html>, there should 
be a test using mtrace.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/18872] Fix memory leak in printf_positional

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18872

--- Comment #3 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to joseph@codesourcery.com from comment #2)
> But as I noted in 
> <https://sourceware.org/ml/libc-alpha/2015-08/msg01096.html>, there should 
> be a test using mtrace.

I agree, but I don't think anyone should spend more than an hour trying to find
such a test case. The static analysis tools can show you a failure, but
actually triggering that failure involves getting coverage over that line of
code, which isn't always trivial. We won't know until we try, but I'd like
anyone looking at the coverity results to be practical about how possible it is
to write a test case to cover the detected failure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/18872] Fix memory leak in printf_positional

[ppluzhnikov at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18872

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppluzhnikov at google dot com
           Assignee|unassigned at sourceware dot org   |ppluzhnikov at google dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/18872] Fix memory leak in printf_positional

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18872

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  560b04462f899e76a0062ec89422caa6e94fd67f (commit)
      from  1f60740e5f03823a557d1543cf08880a11d719de (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=560b04462f899e76a0062ec89422caa6e94fd67f

commit 560b04462f899e76a0062ec89422caa6e94fd67f
Author: Paul Pluzhnikov <ppluzhnikov@google.com>
Date:   Wed Sep 16 09:16:11 2015 -0700

    Fix BZ #18872 -- memory leak in printf_positional.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                          |    9 +++++
 NEWS                               |    2 +-
 stdio-common/Makefile              |   17 ++++++++-
 stdio-common/tst-printf-bz18872.sh |   70 ++++++++++++++++++++++++++++++++++++
 stdio-common/vfprintf.c            |    4 ++
 5 files changed, 100 insertions(+), 2 deletions(-)
 create mode 100644 stdio-common/tst-printf-bz18872.sh

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/18872] Fix memory leak in printf_positional

[ppluzhnikov at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18872

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
Fixed on trunk.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/18872] Fix memory leak in printf_positional

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18872

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.23

-- 
You are receiving this mail because:
You are on the CC list for the bug.