[Bug libc/18877] New: arm: mmap offset regression

[Bug libc/18877] New: arm: mmap offset regression

[ldv at altlinux dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18877

            Bug ID: 18877
           Summary: arm: mmap offset regression
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: ldv at altlinux dot org
                CC: adhemerval.zanella at linaro dot org, drepper.fsp at gmail dot com
  Target Milestone: ---
              Host: armv7hl-redhat-linux-gnu

Commit glibc-2.22-7-g2aa6c8af26e65695e9daf382a6e508574a30cdf2 introduced a
regression in mmap on arm.
If mmap is called with negative offset, it now performs a right shift operation
with sign extension, resulting to incorrect offset being passed to mmap2
syscall.

This regression was detected by strace testsuite.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18877] arm: mmap offset regression

[ldv at altlinux dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18877

--- Comment #1 from Dmitry V. Levin <ldv at altlinux dot org> ---
Created attachment 8555
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8555&action=edit
regression test

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18877] arm: mmap offset regression

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18877

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  d3573f61aca67a398de7eaa7593d3973cb5fd154 (commit)
      from  8c17cb1f6455c7a5fd6a1d05a2394129dbce012b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d3573f61aca67a398de7eaa7593d3973cb5fd154

commit d3573f61aca67a398de7eaa7593d3973cb5fd154
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu Aug 27 16:44:04 2015 -0300

    Fix wordsize-32 mmap offset for negative value (BZ#18877)

    This patch fixes the default wordsize-32 mmap implementation offset
    calculation for negative values.  Current code uses signed shift
    operation to calculate the multiple size to use with syscall and
    it is implementation defined.  Change it to use a division base
    on mmap page size (default being as before, 4096).

    Tested on armv7hf.

        [BZ #18877]
        * posix/Makefile (tests): Add tst-mmap-offset.
        * posix/tst-mmap.c: New file.
        * sysdeps/unix/sysv/linux/generic/wordsize-32/mmap.c (__mmap): Fix
        offset calculation for negative values.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |    9 +++
 NEWS                                               |    2 +-
 posix/Makefile                                     |    2 +-
 posix/tst-mmap-offset.c                            |   67 ++++++++++++++++++++
 sysdeps/unix/sysv/linux/generic/wordsize-32/mmap.c |    8 +-
 5 files changed, 82 insertions(+), 6 deletions(-)
 create mode 100644 posix/tst-mmap-offset.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18877] arm: mmap offset regression

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18877

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Version|unspecified                 |2.23
           Assignee|unassigned at sourceware dot org   |adhemerval.zanella at linaro dot o
                   |                            |rg

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18877] arm: mmap offset regression

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18877

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
Fixed upstream by d3573f61aca67a398de7eaa7593d3973cb5fd154.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/18877] arm: mmap offset regression

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18877

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.23

-- 
You are receiving this mail because:
You are on the CC list for the bug.