[Bug network/20243] Misaligned access in res_query.c HEADER struct

[Bug network/20243] Misaligned access in res_query.c HEADER struct

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20243

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

--- Comment #4 from Sam James <sam at gentoo dot org> ---
Did this ever get landed?
https://sourceware.org/legacy-ml/libc-alpha/2016-06/msg01020.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/20243] Misaligned access in res_query.c HEADER struct

[dave.anglin at bell dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=20243

--- Comment #5 from dave.anglin at bell dot net ---
On 2022-01-30 10:29 p.m., sam at gentoo dot org wrote:
> Did this ever get landed?
No but Debian has been carrying it for some time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/20243] Misaligned access in res_query.c HEADER struct

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20243

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg

--- Comment #6 from Sam James <sam at gentoo dot org> ---
(In reply to dave.anglin from comment #5)
> On 2022-01-30 10:29 p.m., sam at gentoo dot org wrote:
> > Did this ever get landed?
> No but Debian has been carrying it for some time.

I spoke to azanella and we agreed the patch seems reasonable:
[17:44:45]  <azanella> sam_, this has triggered an issue with or1k recently
https://patchwork.sourceware.org/project/glibc/patch/20210614234011.2215641-1-shorne@gmail.com/
and I think the latest patch from david should be ok (although I am not very
found of the packet usage)
[17:52:21]  <sam_> oh I'd missed that one
[18:03:55]  <sam_> are you able to apply it or do I need to ask david to do it?
[18:09:35]  <azanella> sam_, could you please ask sam to repost it, so we can
proper review it? 
[18:39:27]  <sam_> azanella: ofc, will do

Could you resend it to libc-alpha and then we can get this in?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/20243] Misaligned access in res_query.c HEADER struct

[dave.anglin at bell dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=20243

--- Comment #7 from dave.anglin at bell dot net ---
On 2022-03-14 2:40 p.m., sam at gentoo dot org wrote:
> Could you resend it to libc-alpha and then we can get this in?
Will do after recheck on master.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/20243] Misaligned access in res_query.c HEADER struct

[danglin at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20243

--- Comment #8 from John David Anglin <danglin at gcc dot gnu.org> ---
Patch v4 here:
https://sourceware.org/pipermail/libc-alpha/2022-March/137164.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/20243] Misaligned access in res_query.c HEADER struct

[danglin at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20243

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from John David Anglin <danglin at gcc dot gnu.org> ---
commit 05dec22d7be722987ff07aebf9690f6078b3c4e9 (HEAD -> master, origin/master,
origin/HEAD)
Author: John David Anglin <danglin@gcc.gnu.org>
Date:   Tue Mar 22 17:35:54 2022 +0000

    resolv: Fix unaligned accesses to fields in HEADER struct

    The structure HEADER is normally aligned to a word boundary but
    sometimes it needs to be accessed when aligned on a byte boundary.
    This change defines a new typedef, UHEADER, with alignment 1.
    It is used to ensure the fields are accessed with byte loads and
    stores when necessary.

    V4: Change to res_mkquery.c deleted.  Small whitespace fix.

    V5: Move UHEADER typedef to resolv/resolv-internal.h.  Replace all
    HEADER usage with UHEADER in resolv/res_send.c.

    Signed-off-by: John David Anglin <dave.anglin@bell.net>
    Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/20243] Misaligned access in res_query.c HEADER struct

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20243

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=30750

-- 
You are receiving this mail because:
You are on the CC list for the bug.