[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[siddhesh at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

Siddhesh Poyarekar <siddhesh at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |siddhesh at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=26615

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[tuliom at ascii dot art.br]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

Tulio Magno Quites Machado Filho <tuliom at ascii dot art.br> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tuliom at ascii dot art.br

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-12-11
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at sourceware dot org   |fweimer at redhat dot com
     Ever confirmed|0                           |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

--- Comment #7 from Florian Weimer <fweimer at redhat dot com> ---
Patches posted:

https://sourceware.org/pipermail/libc-alpha/2020-December/120635.html
https://sourceware.org/pipermail/libc-alpha/2020-December/120636.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Florian Weimer <fw@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9ffa50b26b0cb5d3043adf6d3d0b1ea735acc147

commit 9ffa50b26b0cb5d3043adf6d3d0b1ea735acc147
Author: Florian Weimer <fweimer@redhat.com>
Date:   Fri Dec 11 17:30:03 2020 +0100

    elf: Include libc.so.6 as main program in dependency sort (bug 20972)

    _dl_map_object_deps always sorts the initially loaded object first
    during dependency sorting.  This means it is relocated last in
    dl_open_worker.  This results in crashes in IFUNC resolvers without
    lazy bindings if libraries are preloaded that refer to IFUNCs in
    libc.so.6: the resolvers are called when libc.so.6 has not been
    relocated yet, so references to _rtld_global_ro etc. crash.

    The fix is to check against the libc.so.6 link map recorded by the
    __libc_early_init framework, and let it participate in the dependency
    sort.

    This fixes bug 20972.

    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.33
             Status|ASSIGNED                    |RESOLVED

--- Comment #9 from Florian Weimer <fweimer at redhat dot com> ---
Fixed for glibc 2.33.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[krizan at eset dot sk]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

--- Comment #10 from Matej Krizan <krizan at eset dot sk> ---
Thanks, Florian.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #11 from Florian Weimer <fweimer at redhat dot com> ---
A follow-up fix is needed:
https://sourceware.org/pipermail/libc-alpha/2020-December/120720.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[shanzhikun at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

Sdrkun <shanzhikun at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shanzhikun at gmail dot com

--- Comment #12 from Sdrkun <shanzhikun at gmail dot com> ---
Hi, Florian, Will this fix be synchronized to glibc 2.28? I think version 2.28
also has this problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

--- Comment #13 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to Sdrkun from comment #12)
> Hi, Florian, Will this fix be synchronized to glibc 2.28? I think version
> 2.28 also has this problem.

I have backported this into 2.28, but changes are rather invasive.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/20972] Running libc.so.6 as an executable triggers IFUNC relocation ordering issues

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20972

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #14 from Florian Weimer <fweimer at redhat dot com> ---
The second fix (also in 2.33):

commit 4d0985543f479a6f421d4d8a9e0d1dc71c9c2c53
Author: Florian Weimer <fweimer@redhat.com>
Date:   Tue Dec 15 20:56:04 2020 +0100

    elf: Record libc.so link map when it is the main program (bug 20972)

    Otherwise, it will not participate in the dependency sorting.

    Fixes commit 9ffa50b26b0cb5d3043adf6d3d0b1ea735acc147
    ("elf: Include libc.so.6 as main program in dependency sort
    (bug 20972)").

    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.