[Bug malloc/22111] malloc: per thread cache is not returned when thread exits

[Bug malloc/22111] malloc: per thread cache is not returned when thread exits

[jeffy.chen@rock-chips.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22111

JeffyChen <jeffy.chen@rock-chips.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeffy.chen@rock-chips.com

--- Comment #12 from JeffyChen <jeffy.chen@rock-chips.com> ---
Hi guys,

It seems this this issue is still exist in some cases, for example i can repro
it with this test in glibc 2.29:

#include <pthread.h>
void *noop() { pthread_detach(pthread_self()); return NULL; }
void main() {
        pthread_t id;
        while(1) pthread_create(&id, NULL, noop, 0);
}

There's also another report at:
https://sourceware.org/ml/glibc-bugs/2018-01/msg00171.html

So it looks like the tcache_shutting_down is still not early enough, when we
detach a thread with no tcache allocated(like the above test), the
tcache_shutting_down would still be false:
static void
tcache_thread_shutdown (void)
{
  int i;
  tcache_perthread_struct *tcache_tmp = tcache;

  if (!tcache)
    return; <--- returned here

  /* Disable the tcache and prevent it from being reinitialized.  */
  tcache = NULL;
  tcache_shutting_down = true; <--- unreachable


And the tcache might be reinitialized later(breakpoint at later
MAYBE_INIT_TCACHE):
Thread 2 (Thread 0x7f993c61e0 (LWP 8920)):
#0  0x0000007f9d444f7c in free () from /lib/libc.so.6
#1  0x0000007f9d57a3e4 in _dl_deallocate_tls () from /lib/ld-linux-aarch64.so.1
#2  0x0000007f9d541490 in free_stacks () from /lib/libpthread.so.0
#3  0x0000007f9d541a4c in __deallocate_stack () from /lib/libpthread.so.0
#4  0x0000007f9d542984 in start_thread () from /lib/libpthread.so.0
#5  0x0000007f9d49b1fc in thread_start () from /lib/libc.so.6



This works:
+++ b/malloc/malloc.c
@@ -2958,13 +2958,14 @@ tcache_thread_shutdown (void)
 {
   int i;
   tcache_perthread_struct *tcache_tmp = tcache;

+  tcache_shutting_down = true;

   if (!tcache)
     return;

   /* Disable the tcache and prevent it from being reinitialized.  */
   tcache = NULL;
-  tcache_shutting_down = true;

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug malloc/22111] malloc: per thread cache is not returned when thread exits

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22111

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=28028

--- Comment #13 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to JeffyChen from comment #12)
> Hi guys,
> 
> It seems this this issue is still exist in some cases, for example i can
> repro it with this test in glibc 2.29:

Thanks for the report, this is now bug 28028.

-- 
You are receiving this mail because:
You are on the CC list for the bug.