[Bug dynamic-link/23462] Static binary with dynamic string tokens crashes.

[Bug dynamic-link/23462] Static binary with dynamic string tokens crashes.

[christoph.hoeger at celeraone dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23462

Christoph Höger <christoph.hoeger at celeraone dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christoph.hoeger@celeraone.
                   |                            |com

--- Comment #2 from Christoph Höger <christoph.hoeger at celeraone dot com> ---
This bug just hit me during a bootstrap of gcc, as the tls detection macro
attempts a compilation with -static and is happy if compilation fails but
unhappy if there is a segfault later on:

https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=config/tls.m4;h=7532305b908abf8c9874d466dc91eeed18954933;hb=HEAD#l12

The bug still persists in 2.32 - @Carlos

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/23462] Static binary with dynamic string tokens crashes.

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23462

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adrien.mahieux at gmail dot com

--- Comment #3 from Florian Weimer <fweimer at redhat dot com> ---
*** Bug 27499 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/23462] Static binary with dynamic string tokens ($LIB, $PLATFORM, $ORIGIN) crashes

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23462

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Static binary with dynamic  |Static binary with dynamic
                   |string tokens crashes.      |string tokens ($LIB,
                   |                            |$PLATFORM, $ORIGIN) crashes

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/23462] Static binary with dynamic string tokens ($LIB, $PLATFORM, $ORIGIN) crashes

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23462

--- Comment #4 from Carlos O'Donell <carlos at redhat dot com> ---
We have an upstream patch for this, but the consequences are not entirely
trivial, we have to consider what happens for static binaries. Thanks for
Florian for initial review.

https://patchwork.sourceware.org/project/glibc/patch/ca723e73-c8eb-ca4c-1ca0-5fbf2b88edcd@redhat.com/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/23462] Static binary with dynamic string tokens ($LIB, $PLATFORM, $ORIGIN) crashes

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23462

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|carlos at redhat dot com           |fweimer at redhat dot com

--- Comment #5 from Florian Weimer <fweimer at redhat dot com> ---
I'm going to post an updated patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/23462] Static binary with dynamic string tokens ($LIB, $PLATFORM, $ORIGIN) crashes

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23462

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |2.34

--- Comment #6 from Florian Weimer <fweimer at redhat dot com> ---
Fixed for glibc 2.34 via:

commit 332421312576bd7095e70589154af99b124dd2d1
Author: Carlos O'Donell <carlos@redhat.com>
Date:   Fri Mar 12 16:44:47 2021 +0100

    elf: Always set l in _dl_init_paths (bug 23462)

    After d1d5471579eb0426671bf94f2d71e61dfb204c30 ("Remove dead
    DL_DST_REQ_STATIC code.") we always setup the link map l to make the
    static and shared cases the same.  The bug is that in elf/dl-load.c
    (_dl_init_paths) we conditionally set l only in the #ifdef SHARED
    case, but unconditionally use it later.  The simple solution is to
    remove the #ifdef SHARED conditional, because it's no longer needed,
    and unconditionally setup l for both the static and shared cases. A
    regression test is added to run a static binary with
    LD_LIBRARY_PATH='$ORIGIN' which crashes before the fix and runs after
    the fix.

    Co-Authored-By: Florian Weimer <fweimer@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/23462] Static binary with dynamic string tokens ($LIB, $PLATFORM, $ORIGIN) crashes

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23462

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=27577

-- 
You are receiving this mail because:
You are on the CC list for the bug.