[Bug string/23631] strstr testing is inadequate

[Bug string/23631] strstr testing is inadequate

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23631

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |carlos at redhat dot com
             Status|NEW                         |RESOLVED

--- Comment #2 from Carlos O'Donell <carlos at redhat dot com> ---
We test all the possible IFUNC implementations with FOR_EACH_IMPL.

Improved significantly with:

commit bfdb731438206b0f70fe7afa890681155c30b419
Author: Stefan Liebler <stli@linux.ibm.com>
Date:   Wed Nov 27 12:35:40 2019 +0100

    S390: Fix handling of needles crossing a page in strstr z15 ifunc-variant.
[BZ #25226]

    If the specified needle crosses a page-boundary, the s390-z15 ifunc variant
of
    strstr truncates the needle which results in invalid results.

    This is fixed by loading the needle beyond the page boundary to v18 instead
of v16.
    The bug is sometimes observable in test-strstr.c in check1 and check2 as
the
    haystack and needle is stored on stack. Thus the needle can be on a page
boundary.

    check2 is now extended to test haystack / needles located on stack, at end
of page
    and on two pages.

    This bug was introduced with commit
6f47401bd5fc71209219779a0426170a9a7395b0
    ("S390: Add arch13 strstr ifunc variant.") and is already released in glibc
2.30.

-- 
You are receiving this mail because:
You are on the CC list for the bug.