public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
@ 2020-10-27 11:34 ` adhemerval.zanella at linaro dot org
  2020-10-27 11:37 ` fweimer at redhat dot com
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 12+ messages in thread
From: adhemerval.zanella at linaro dot org @ 2020-10-27 11:34 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg

--- Comment #1 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
This simplifies the expectation of the interface, but this might characterize
as a semantic change. Should we add compat symbols for the case we hardcode the
shm folder? The symbol affects are sem_open, sem_unlink, shm_open, and
shm_unlink.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
  2020-10-27 11:34 ` [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory adhemerval.zanella at linaro dot org
@ 2020-10-27 11:37 ` fweimer at redhat dot com
  2020-10-27 11:38 ` adhemerval.zanella at linaro dot org
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 12+ messages in thread
From: fweimer at redhat dot com @ 2020-10-27 11:37 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
I don't think compat symbols are required because the change is not observable
on a correctly configured system. The current behavior is buggy.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
  2020-10-27 11:34 ` [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory adhemerval.zanella at linaro dot org
  2020-10-27 11:37 ` fweimer at redhat dot com
@ 2020-10-27 11:38 ` adhemerval.zanella at linaro dot org
  2020-10-27 11:39 ` adhemerval.zanella at linaro dot org
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 12+ messages in thread
From: adhemerval.zanella at linaro dot org @ 2020-10-27 11:38 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |adhemerval.zanella at linaro dot o
                   |                            |rg

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2020-10-27 11:38 ` adhemerval.zanella at linaro dot org
@ 2020-10-27 11:39 ` adhemerval.zanella at linaro dot org
  2020-10-27 11:41 ` fweimer at redhat dot com
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 12+ messages in thread
From: adhemerval.zanella at linaro dot org @ 2020-10-27 11:39 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

--- Comment #3 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
Alright, i think we can move with this assumption and just remove the fallback
code that parses /proc/mounts.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2020-10-27 11:39 ` adhemerval.zanella at linaro dot org
@ 2020-10-27 11:41 ` fweimer at redhat dot com
  2020-10-27 11:43 ` fweimer at redhat dot com
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 12+ messages in thread
From: fweimer at redhat dot com @ 2020-10-27 11:41 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

--- Comment #4 from Florian Weimer <fweimer at redhat dot com> ---
I think I have a patch for this locally, but it seems I have not posted it so
far.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2020-10-27 11:41 ` fweimer at redhat dot com
@ 2020-10-27 11:43 ` fweimer at redhat dot com
  2020-10-27 11:47 ` fweimer at redhat dot com
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 12+ messages in thread
From: fweimer at redhat dot com @ 2020-10-27 11:43 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

--- Comment #5 from Florian Weimer <fweimer at redhat dot com> ---
* adhemerval zanella at linaro dot org:

> https://sourceware.org/bugzilla/show_bug.cgi?id=25383
>
> Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>            Assignee|unassigned at sourceware dot org   |adhemerval.zanella at linaro dot o
>                    |                            |rg

This is my existing patch I found lying around.

Should I rebase it, clean it up, and post it?

Thanks,
Florian

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
                   ` (5 preceding siblings ...)
  2020-10-27 11:43 ` fweimer at redhat dot com
@ 2020-10-27 11:47 ` fweimer at redhat dot com
  2020-10-27 12:06 ` adhemerval.zanella at linaro dot org
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 12+ messages in thread
From: fweimer at redhat dot com @ 2020-10-27 11:47 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|adhemerval.zanella at linaro dot o |fweimer at redhat dot com
                   |rg                          |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
                   ` (6 preceding siblings ...)
  2020-10-27 11:47 ` fweimer at redhat dot com
@ 2020-10-27 12:06 ` adhemerval.zanella at linaro dot org
  2021-02-02 19:22 ` fweimer at redhat dot com
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 12+ messages in thread
From: adhemerval.zanella at linaro dot org @ 2020-10-27 12:06 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

--- Comment #6 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
(In reply to Florian Weimer from comment #5)
> Created attachment 12921 [details]
> shm.patch
> 
> * adhemerval zanella at linaro dot org:
> 
> > https://sourceware.org/bugzilla/show_bug.cgi?id=25383
> >
> > Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:
> >
> >            What    |Removed                     |Added
> > ----------------------------------------------------------------------------
> >            Assignee|unassigned at sourceware dot org   |adhemerval.zanella at linaro dot o
> >                    |                            |rg
> 
> This is my existing patch I found lying around.
> 
> Should I rebase it, clean it up, and post it?

This looks ok, I would remove the shmdir_name and use a plain array instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
                   ` (7 preceding siblings ...)
  2020-10-27 12:06 ` adhemerval.zanella at linaro dot org
@ 2021-02-02 19:22 ` fweimer at redhat dot com
  2021-02-08 17:13 ` adhemerval.zanella at linaro dot org
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 12+ messages in thread
From: fweimer at redhat dot com @ 2021-02-02 19:22 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |crrodriguez at opensuse dot org

--- Comment #7 from Florian Weimer <fweimer at redhat dot com> ---
*** Bug 27316 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
                   ` (8 preceding siblings ...)
  2021-02-02 19:22 ` fweimer at redhat dot com
@ 2021-02-08 17:13 ` adhemerval.zanella at linaro dot org
  2021-02-08 17:23 ` fweimer at redhat dot com
  2021-02-08 17:41 ` schwab@linux-m68k.org
  11 siblings, 0 replies; 12+ messages in thread
From: adhemerval.zanella at linaro dot org @ 2021-02-08 17:13 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTABUG
   Target Milestone|---                         |2.34
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
Fixed on 2.34.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
                   ` (9 preceding siblings ...)
  2021-02-08 17:13 ` adhemerval.zanella at linaro dot org
@ 2021-02-08 17:23 ` fweimer at redhat dot com
  2021-02-08 17:41 ` schwab@linux-m68k.org
  11 siblings, 0 replies; 12+ messages in thread
From: fweimer at redhat dot com @ 2021-02-08 17:23 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

--- Comment #9 from Florian Weimer <fweimer at redhat dot com> ---
Commit:

commit e9fed2438a1ff475821864f906286dc58907f06b
Author: Florian Weimer <fweimer@redhat.com>
Date:   Wed Feb 3 08:55:13 2021 -0300

    linux: Require /dev/shm as the shared memory file system

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory
       [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
                   ` (10 preceding siblings ...)
  2021-02-08 17:23 ` fweimer at redhat dot com
@ 2021-02-08 17:41 ` schwab@linux-m68k.org
  11 siblings, 0 replies; 12+ messages in thread
From: schwab@linux-m68k.org @ 2021-02-08 17:41 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25383

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|NOTABUG                     |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-02-08 17:41 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-25383-131@http.sourceware.org/bugzilla/>
2020-10-27 11:34 ` [Bug libc/25383] where_is_shmfs/__shm_directory/SHM_GET_NAME may cause shm_open to pick wrong directory adhemerval.zanella at linaro dot org
2020-10-27 11:37 ` fweimer at redhat dot com
2020-10-27 11:38 ` adhemerval.zanella at linaro dot org
2020-10-27 11:39 ` adhemerval.zanella at linaro dot org
2020-10-27 11:41 ` fweimer at redhat dot com
2020-10-27 11:43 ` fweimer at redhat dot com
2020-10-27 11:47 ` fweimer at redhat dot com
2020-10-27 12:06 ` adhemerval.zanella at linaro dot org
2021-02-02 19:22 ` fweimer at redhat dot com
2021-02-08 17:13 ` adhemerval.zanella at linaro dot org
2021-02-08 17:23 ` fweimer at redhat dot com
2021-02-08 17:41 ` schwab@linux-m68k.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).