[Bug build/25652] New: testroot.pristine misses /lib64/ld-linux-x86-64.so.2

[Bug build/25652] New: testroot.pristine misses /lib64/ld-linux-x86-64.so.2

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25652

            Bug ID: 25652
           Summary: testroot.pristine misses /lib64/ld-linux-x86-64.so.2
           Product: glibc
           Version: 2.31
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: michael.hudson at canonical dot com
                CC: carlos at redhat dot com
  Target Milestone: ---

In the process of updating Ubuntu to glibc 2.31, the following tests fail in
the autopkgtest infrastructure:

FAIL: elf/tst-dlopen-self-container
FAIL: elf/tst-dlopen-tlsmodid-container
FAIL: elf/tst-ldconfig-bad-aux-cache
FAIL: elf/tst-ldconfig-ld_so_conf-update
FAIL: elf/tst-pldd
FAIL: nss/tst-nss-db-endgrent
FAIL: nss/tst-nss-db-endpwent
FAIL: nss/tst-nss-files-hosts-long

(full log at
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/g/glibc/20200310_034140_bacc4@/log.gz)

These tests all use test-container.c and fail like so:

error: test-container.c:1096: Unable to exec
/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/elf/tst-dlopen-self-container

(because our builds run in a chroot, these tests are skipped at build time)

A little digging reveals that the missing file is the interpreter,
/lib64/ld-linux-x86-64.so.2, and indeed this is not present in
testroot.pristine:

$ ls testroot.pristine/
bin  lib  tmp  usr

What's going on? Well, the code that's supposed to copy this across is:

        for dso in `$(test-wrapper-env) LD_TRACE_LOADED_OBJECTS=1  \
                $(rtld-prefix) \
                $(objpfx)testroot.pristine/bin/sh \
                | sed -n '/\//{s@.*=> /@/@;s/^[^/]*//;s/ .*//p;}'` ;\
          do \
            test -d `dirname $(objpfx)testroot.pristine$$dso` || \
              mkdir -p `dirname $(objpfx)testroot.pristine$$dso` ;\
            $(test-wrapper) cp $$dso $(objpfx)testroot.pristine$$dso ;\
          done

Which, in the context of this test run became:

for dso in ` env LD_TRACE_LOADED_OBJECTS=1  \
       
/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/elf/ld-linux-x86-64.so.2
--library-path
/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc:/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/math:/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/elf:/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/dlfcn:/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/nss:/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/nis:/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/rt:/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/resolv:/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/mathvec:/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/support:/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/nptl
\
       
/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/testroot.pristine/bin/sh
\
        | sed -n '/\//{s@.*=> /@/@;s/^[^/]*//;s/ .*//p;}'` ;\
  do \
    test -d `dirname
/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/testroot.pristine$dso`
|| \
      mkdir -p `dirname
/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/testroot.pristine$dso`
;\
     cp $dso
/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/testroot.pristine$dso
;\
  done

The output of the LD_TRACE_LOADED_OBJECTS=1 .. | sed pipeline is this:

/lib/x86_64-linux-gnu/libc.so.6
/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/elf/ld-linux-x86-64.so.2

So the interpreter gets copied to
testroot.pristine/tmp/autopkgtest.YturSE/build.WyJ/src/build-tree/amd64-libc/elf/ld-linux-x86-64.so.2
which is obviously of no use to anyone.

I'm not sure I'm competent to suggest a fix. Removing the line containing "    
        $(rtld-prefix)" seems to help and maybe makes sense -- after all, the
goal is surely to get files into testroot.pristine that
testroot.pristine/bin/sh will look for by default -- but I'm not sure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/25652] testroot.pristine misses /lib64/ld-linux-x86-64.so.2

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25652

Michael Hudson-Doyle <michael.hudson at canonical dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hudson at canonical dot co
                   |                            |m

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/25652] testroot.pristine misses /lib64/ld-linux-x86-64.so.2

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25652

--- Comment #1 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Michael Hudson-Doyle from comment #0)
> $ ls testroot.pristine/
> bin  lib  tmp  usr

What's in lib? find testroot.pristine/lib/?

> What's going on? Well, the code that's supposed to copy this across is:

The intent of this code is to copy any additional required objects from the
language runtime.

The subsequence "make install" installs everything you need.

> I'm not sure I'm competent to suggest a fix. Removing the line containing "	
> $(rtld-prefix)" seems to help and maybe makes sense -- after all, the goal
> is surely to get files into testroot.pristine that testroot.pristine/bin/sh
> will look for by default -- but I'm not sure.

Can you please run ldd on the tst-dlopen-self-container test?

It seems like you make have a disconnected between how the tests are built and
what is actually installed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/25652] testroot.pristine misses /lib64/ld-linux-x86-64.so.2

[fw at deneb dot enyo.de]

https://sourceware.org/bugzilla/show_bug.cgi?id=25652

Florian Weimer <fw at deneb dot enyo.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fw at deneb dot enyo.de
              Flags|                            |security-

--- Comment #2 from Florian Weimer <fw at deneb dot enyo.de> ---
Does this issue reproduce if you back out the multi-arch path patches (which
are not upstream)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/25652] testroot.pristine misses /lib64/ld-linux-x86-64.so.2

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25652

--- Comment #3 from Michael Hudson-Doyle <michael.hudson at canonical dot com> ---
Sorry for the delay, I accidentally destroyed the vm I had been running the
tests in.

(In reply to Carlos O'Donell from comment #1)
> (In reply to Michael Hudson-Doyle from comment #0)
> > $ ls testroot.pristine/
> > bin  lib  tmp  usr
> 
> What's in lib? find testroot.pristine/lib/?

This looks OK:

ubuntu@autopkgtest:/tmp/autopkgtest.aD5exj/build.jIB/real-tree/build-tree/amd64-libc$
find testroot.pristine/lib/
testroot.pristine/lib/
testroot.pristine/lib/x86_64-linux-gnu
testroot.pristine/lib/x86_64-linux-gnu/libthread_db.so.1
testroot.pristine/lib/x86_64-linux-gnu/libanl-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/librt.so.1
testroot.pristine/lib/x86_64-linux-gnu/libdl-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libmvec-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libmvec.so.1
testroot.pristine/lib/x86_64-linux-gnu/librt-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libpthread-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libnss_files-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libSegFault.so
testroot.pristine/lib/x86_64-linux-gnu/libnsl-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libresolv-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libstdc++.so.6
testroot.pristine/lib/x86_64-linux-gnu/libnss_dns.so.2
testroot.pristine/lib/x86_64-linux-gnu/libnss_nisplus.so.2
testroot.pristine/lib/x86_64-linux-gnu/libnss_hesiod.so.2
testroot.pristine/lib/x86_64-linux-gnu/libgcc_s.so.1
testroot.pristine/lib/x86_64-linux-gnu/libm-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libnss_files.so.2
testroot.pristine/lib/x86_64-linux-gnu/libm.so.6
testroot.pristine/lib/x86_64-linux-gnu/libutil-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libnss_nis-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libc.so.6
testroot.pristine/lib/x86_64-linux-gnu/libthread_db-1.0.so
testroot.pristine/lib/x86_64-linux-gnu/libpthread.so.0
testroot.pristine/lib/x86_64-linux-gnu/libBrokenLocale-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libnss_dns-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libmemusage.so
testroot.pristine/lib/x86_64-linux-gnu/libc-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libnss_nis.so.2
testroot.pristine/lib/x86_64-linux-gnu/libnsl.so.1
testroot.pristine/lib/x86_64-linux-gnu/libutil.so.1
testroot.pristine/lib/x86_64-linux-gnu/libpcprofile.so
testroot.pristine/lib/x86_64-linux-gnu/ld-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libresolv.so.2
testroot.pristine/lib/x86_64-linux-gnu/libnss_compat.so.2
testroot.pristine/lib/x86_64-linux-gnu/libBrokenLocale.so.1
testroot.pristine/lib/x86_64-linux-gnu/libnss_compat-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libdl.so.2
testroot.pristine/lib/x86_64-linux-gnu/libnss_nisplus-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2
testroot.pristine/lib/x86_64-linux-gnu/libnss_hesiod-2.31.so
testroot.pristine/lib/x86_64-linux-gnu/libanl.so.1

> > What's going on? Well, the code that's supposed to copy this across is:
> 
> The intent of this code is to copy any additional required objects from the
> language runtime.
> 
> The subsequence "make install" installs everything you need.
>  
> > I'm not sure I'm competent to suggest a fix. Removing the line containing "	
> > $(rtld-prefix)" seems to help and maybe makes sense -- after all, the goal
> > is surely to get files into testroot.pristine that testroot.pristine/bin/sh
> > will look for by default -- but I'm not sure.
> 
> Can you please run ldd on the tst-dlopen-self-container test?

ubuntu@autopkgtest:/tmp/autopkgtest.aD5exj/build.jIB/real-tree/build-tree/amd64-libc$
ldd ./elf/tst-dlopen-self-container
        linux-vdso.so.1 (0x00007ffdf03e8000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fc91af78000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fc91ad87000)
        /lib64/ld-linux-x86-64.so.2 (0x00007fc91af90000)


> It seems like you make have a disconnected between how the tests are built
> and what is actually installed.

(In reply to Florian Weimer from comment #2)
> Does this issue reproduce if you back out the multi-arch path patches (which
> are not upstream)?

Do you mean just commenting these two patches out of debian/patches/series:

debian/patches/any/local-ldconfig-multiarch.diff
debian/patches/any/local-ld-multiarch.diff

and trying again?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/25652] testroot.pristine misses /lib64/ld-linux-x86-64.so.2

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25652

--- Comment #4 from Michael Hudson-Doyle <michael.hudson at canonical dot com> ---
> (In reply to Florian Weimer from comment #2)
> > Does this issue reproduce if you back out the multi-arch path patches (which
> > are not upstream)?
> 
> Do you mean just commenting these two patches out of debian/patches/series:
> 
> debian/patches/any/local-ldconfig-multiarch.diff
> debian/patches/any/local-ld-multiarch.diff
> 
> and trying again?

If that is what you meant, it didn't make any difference.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/25652] testroot.pristine misses /lib64/ld-linux-x86-64.so.2

[aurelien at aurel32 dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=25652

Aurelien Jarno <aurelien at aurel32 dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aurelien at aurel32 dot net

--- Comment #5 from Aurelien Jarno <aurelien at aurel32 dot net> ---
This has nothing to do with multiarch.

The issue is caused by the quick and dirty patch
"debian/patches/any/local-rtlddir-cross.diff" that was added to avoid modifying
at the dpkg-cross tool, which mangle packages to move libraries from native
path to a cross path.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/25652] testroot.pristine misses /lib64/ld-linux-x86-64.so.2

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25652

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
                 CC|                            |fweimer at redhat dot com
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-08-24

--- Comment #6 from Florian Weimer <fweimer at redhat dot com> ---
Thanks for tracking this down. Does this mean it's a downstream-only bug?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/25652] testroot.pristine misses /lib64/ld-linux-x86-64.so.2

[aurelien at aurel32 dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=25652

--- Comment #7 from Aurelien Jarno <aurelien at aurel32 dot net> ---
(In reply to Florian Weimer from comment #6)
> Thanks for tracking this down. Does this mean it's a downstream-only bug?

Yes, we inherited the same bug in Debian from Ubuntu. After removing that patch
a few months ago in Debian glibc 2.31-12, the issue disappeared. Sorry for the
delay, I have just discovered that bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/25652] testroot.pristine misses /lib64/ld-linux-x86-64.so.2

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25652

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTABUG
             Status|WAITING                     |RESOLVED

--- Comment #8 from Florian Weimer <fweimer at redhat dot com> ---
Thanks. Closing per comment 7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.