[Bug build/25836] New: Test container not properly created when running single test

[Bug build/25836] New: Test container not properly created when running single test

[msc at linux dot ibm.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25836

            Bug ID: 25836
           Summary: Test container not properly created when running
                    single test
           Product: glibc
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: msc at linux dot ibm.com
                CC: carlos at redhat dot com
  Target Milestone: ---

I recently noticed that trying to run a single containerized test using `make
test t=<...>` fails if run before `make check`.

For example, right after building glibc:
$ make test t=stdlib/tst-system
[...]
FAIL: stdlib/tst-system
original exit status 1
error: test-container.c:766: Cannot create testroot lock.

I've tried this with many tests that use containers and the results are always
the same.

Apparently this happens because testroot.* directories are not properly created
in such cases:
~/build/glibc$ ls testroot.pristine
ls: cannot access 'testroot.pristine': No such file or directory
~/build/glibc$ ls testroot.root
ls: cannot access 'testroot.root': No such file or directory

The rule to create testroot.pristine is in the top-level Makefile:
$(tests-container) $(addsuffix /tests,$(subdirs)) : \
                $(objpfx)testroot.pristine/install.stamp

However `tests-container` is only defined by each subdir Makefile, so this rule
is never triggered for individual tests, as `tests-container` is always empty
in
this context.

Tested with commit c580e6466d6da8262820cdbad19f32c5546226cf.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/25836] Test container not properly created when running single test

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25836

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2020-04-16
     Ever confirmed|0                           |1

--- Comment #1 from Carlos O'Donell <carlos at redhat dot com> ---
This is just a limitation of the implementation of the helper targets.

You could probably detect the container rootfs is missing and generate it, and
then use the stamp to never do that again.

Note: We are still unable to dynamically update the rootfs when the
implementation changes, so that will not be resolved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/25836] Test container not properly created when running single test

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25836

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.