public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/25902] New: INLINE_SYSCALL_CALL doesn't work with variadic arguments
@ 2020-04-30 22:42 hjl.tools at gmail dot com
  2020-04-30 22:46 ` [Bug libc/25902] INLINE_SYSCALL_CALL is wrong hjl.tools at gmail dot com
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: hjl.tools at gmail dot com @ 2020-04-30 22:42 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25902

            Bug ID: 25902
           Summary: INLINE_SYSCALL_CALL doesn't work with variadic
                    arguments
           Product: glibc
           Version: 2.32
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---
            Target: powerpc

The newly added sysdeps/unix/sysv/linux/prctl.c passes variadic arguments
to INLINE_SYSCALL_CALL.  But it doesn't work on PPC:

../sysdeps/unix/sysv/linux/prctl.c: In function ‘__prctl’:
../sysdeps/unix/sysv/linux/prctl.c:36:21: error: unused variable ‘arg5’
[-Werror=unused-variable]
   36 |   unsigned long int arg5 = va_arg (arg, unsigned long int);
      |                     ^~~~
../sysdeps/unix/sysv/linux/prctl.c:35:21: error: unused variable ‘arg4’
[-Werror=unused-variable]
   35 |   unsigned long int arg4 = va_arg (arg, unsigned long int);
      |                     ^~~~
../sysdeps/unix/sysv/linux/prctl.c:34:21: error: unused variable ‘arg3’
[-Werror=unused-variable]
   34 |   unsigned long int arg3 = va_arg (arg, unsigned long int);
      |                     ^~~~
../sysdeps/unix/sysv/linux/prctl.c:33:21: error: unused variable ‘arg2’
[-Werror=unused-variable]
   33 |   unsigned long int arg2 = va_arg (arg, unsigned long int);
      |                     ^~~~

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libc/25902] INLINE_SYSCALL_CALL is wrong
  2020-04-30 22:42 [Bug libc/25902] New: INLINE_SYSCALL_CALL doesn't work with variadic arguments hjl.tools at gmail dot com
@ 2020-04-30 22:46 ` hjl.tools at gmail dot com
  2020-04-30 22:52 ` hjl.tools at gmail dot com
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: hjl.tools at gmail dot com @ 2020-04-30 22:46 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25902

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|INLINE_SYSCALL_CALL doesn't |INLINE_SYSCALL_CALL is
                   |work with variadic          |wrong
                   |arguments                   |

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
#define LOADARGS_5(name, __arg1, __arg2, __arg3, __arg4, __arg5) \
        long int arg5 = (long int) (__arg5); \
        LOADARGS_4(name, __arg1, __arg2, __arg3, __arg4); \
        extern void __illegally_sized_syscall_arg5 (void); \
        if (__builtin_classify_type (__arg5) != 5 \
            && sizeof (__arg5) > SYSCALL_ARG_SIZE) \
          __illegally_sized_syscall_arg5 (); \
        r7 = arg5

uses arg5.  But it is also function argument.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libc/25902] INLINE_SYSCALL_CALL is wrong
  2020-04-30 22:42 [Bug libc/25902] New: INLINE_SYSCALL_CALL doesn't work with variadic arguments hjl.tools at gmail dot com
  2020-04-30 22:46 ` [Bug libc/25902] INLINE_SYSCALL_CALL is wrong hjl.tools at gmail dot com
@ 2020-04-30 22:52 ` hjl.tools at gmail dot com
  2020-04-30 22:56 ` [Bug libc/25902] Bad LOADARGS_N hjl.tools at gmail dot com
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: hjl.tools at gmail dot com @ 2020-04-30 22:52 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25902

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 12497
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12497&action=edit
A patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libc/25902] Bad LOADARGS_N
  2020-04-30 22:42 [Bug libc/25902] New: INLINE_SYSCALL_CALL doesn't work with variadic arguments hjl.tools at gmail dot com
  2020-04-30 22:46 ` [Bug libc/25902] INLINE_SYSCALL_CALL is wrong hjl.tools at gmail dot com
  2020-04-30 22:52 ` hjl.tools at gmail dot com
@ 2020-04-30 22:56 ` hjl.tools at gmail dot com
  2020-05-01  2:04 ` tuliom at ascii dot art.br
  2020-05-07 12:32 ` hjl.tools at gmail dot com
  4 siblings, 0 replies; 6+ messages in thread
From: hjl.tools at gmail dot com @ 2020-04-30 22:56 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25902

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|INLINE_SYSCALL_CALL is      |Bad LOADARGS_N
                   |wrong                       |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libc/25902] Bad LOADARGS_N
  2020-04-30 22:42 [Bug libc/25902] New: INLINE_SYSCALL_CALL doesn't work with variadic arguments hjl.tools at gmail dot com
                   ` (2 preceding siblings ...)
  2020-04-30 22:56 ` [Bug libc/25902] Bad LOADARGS_N hjl.tools at gmail dot com
@ 2020-05-01  2:04 ` tuliom at ascii dot art.br
  2020-05-07 12:32 ` hjl.tools at gmail dot com
  4 siblings, 0 replies; 6+ messages in thread
From: tuliom at ascii dot art.br @ 2020-05-01  2:04 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25902

Tulio Magno Quites Machado Filho <tuliom at ascii dot art.br> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tuliom at ascii dot art.br

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libc/25902] Bad LOADARGS_N
  2020-04-30 22:42 [Bug libc/25902] New: INLINE_SYSCALL_CALL doesn't work with variadic arguments hjl.tools at gmail dot com
                   ` (3 preceding siblings ...)
  2020-05-01  2:04 ` tuliom at ascii dot art.br
@ 2020-05-07 12:32 ` hjl.tools at gmail dot com
  4 siblings, 0 replies; 6+ messages in thread
From: hjl.tools at gmail dot com @ 2020-05-07 12:32 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=25902

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.32
             Status|NEW                         |RESOLVED

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for 2.32 and 2.30/2.31 branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-05-07 12:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 22:42 [Bug libc/25902] New: INLINE_SYSCALL_CALL doesn't work with variadic arguments hjl.tools at gmail dot com
2020-04-30 22:46 ` [Bug libc/25902] INLINE_SYSCALL_CALL is wrong hjl.tools at gmail dot com
2020-04-30 22:52 ` hjl.tools at gmail dot com
2020-04-30 22:56 ` [Bug libc/25902] Bad LOADARGS_N hjl.tools at gmail dot com
2020-05-01  2:04 ` tuliom at ascii dot art.br
2020-05-07 12:32 ` hjl.tools at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).