[Bug libc/25954] New: Missing content-synchronizing instructions in pkey_set on POWER

[Bug libc/25954] New: Missing content-synchronizing instructions in pkey_set on POWER

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25954

            Bug ID: 25954
           Summary: Missing content-synchronizing instructions in pkey_set
                    on POWER
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: fweimer at redhat dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---
            Target: powerpc64*
             Flags: security-

Sandipan Das reported this bug against the kernel protection key self-tests:

“
The Power ISA mandates that all writes to the Authority
Mask Register (AMR) must always be preceded as well as
succeeded by a context-synchronizing instruction. This
applies to both the privileged and unprivileged variants
of the Move To AMR instruction.

This [requirement] is from Table 6 of Chapter 11 in page 1134 of Power
ISA 3.0B. The document can be found here:
https://ibm.ent.box.com/s/1hzcwkwf8rbju5h9iyf44wm94amnlcrv
”

<https://lore.kernel.org/linuxppc-dev/5f65cf37be993760de8112a88da194e3ccbb2bf8.1588959697.git.sandipan@linux.ibm.com/>

We need to add these additonal instructions to the pkey_set implementation in
glibc, too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/25954] Missing content-synchronizing instructions in pkey_set on POWER

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25954

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=23202

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/25954] Missing context-synchronizing instructions in pkey_set on POWER

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25954

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Missing                     |Missing
                   |content-synchronizing       |context-synchronizing
                   |instructions in pkey_set on |instructions in pkey_set on
                   |POWER                       |POWER

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/25954] Missing context-synchronizing instructions in pkey_set on POWER

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25954

--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
Patch posted: https://sourceware.org/pipermail/libc-alpha/2020-May/113779.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/25954] Missing context-synchronizing instructions in pkey_set on POWER

[tuliom at ascii dot art.br]

https://sourceware.org/bugzilla/show_bug.cgi?id=25954

Tulio Magno Quites Machado Filho <tuliom at ascii dot art.br> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tuliom at ascii dot art.br

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/25954] Missing context-synchronizing instructions in pkey_set on POWER

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25954

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
Fixed for 2.32 via:

commit e627106266ad8785457fadbf5bf67ed604d2a353
Author: Florian Weimer <fweimer@redhat.com>
Date:   Mon May 11 11:20:02 2020 +0200

    POWER: Add context-synchronizing instructions to pkey_write [BZ #25954]

    Sandipan Das reported that,

    "The Power ISA mandates that all writes to the Authority
    Mask Register (AMR) must always be preceded as well as
    succeeded by a context-synchronizing instruction. This
    applies to both the privileged and unprivileged variants
    of the Move To AMR instruction.

    This [requirement] is from Table 6 of Chapter 11 in page 1134 of Power
    ISA 3.0B. The document can be found here:
    <https://ibm.ent.box.com/s/1hzcwkwf8rbju5h9iyf44wm94amnlcrv>
    "

    See this kernel patch submission:

   
<https://lore.kernel.org/linuxppc-dev/5f65cf37be993760de8112a88da194e3ccbb2bf8.1588959697.git.sandipan@linux.ibm.com/>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/25954] Missing context-synchronizing instructions in pkey_set on POWER

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25954

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.32

-- 
You are receiving this mail because:
You are on the CC list for the bug.