[Bug libc/25967] New: test-errno.c can't be compiled by GCC 10

[Bug libc/25967] New: test-errno.c can't be compiled by GCC 10

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25967

            Bug ID: 25967
           Summary: test-errno.c can't be compiled by GCC 10
           Product: glibc
           Version: 2.32
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

On x86-64, I got

cc test-errno.c -c -std=gnu11 -fgnu89-inline  -O2 -g -Wall -Wwrite-strings
-Wundef -Werror -fmerge-all-constants -frounding-math -fno-stack-protector
-Wstrict-prototypes -Wold-style-definition -fmath-errno            -I../include
-I/export/build/gnu/tools-build/glibc/build-x86_64-linux/posix 
-I/export/build/gnu/tools-build/glibc/build-x86_64-linux 
-I../sysdeps/unix/sysv/linux/x86_64/64  -I../sysdeps/unix/sysv/linux/x86_64 
-I../sysdeps/unix/sysv/linux/x86/include -I../sysdeps/unix/sysv/linux/x86 
-I../sysdeps/x86/nptl  -I../sysdeps/unix/sysv/linux/wordsize-64 
-I../sysdeps/x86_64/nptl  -I../sysdeps/unix/sysv/linux/include
-I../sysdeps/unix/sysv/linux  -I../sysdeps/nptl  -I../sysdeps/pthread 
-I../sysdeps/gnu  -I../sysdeps/unix/inet  -I../sysdeps/unix/sysv 
-I../sysdeps/unix/x86_64  -I../sysdeps/unix  -I../sysdeps/posix 
-I../sysdeps/x86_64/64  -I../sysdeps/x86_64/fpu/multiarch 
-I../sysdeps/x86_64/fpu  -I../sysdeps/x86/fpu  -I../sysdeps/x86_64/multiarch 
-I../sysdeps/x86_64  -I../sysdeps/x86  -I../sysdeps/ieee754/float128 
-I../sysdeps/ieee754/ldbl-96/include -I../sysdeps/ieee754/ldbl-96 
-I../sysdeps/ieee754/dbl-64/wordsize-64  -I../sysdeps/ieee754/dbl-64 
-I../sysdeps/ieee754/flt-32  -I../sysdeps/wordsize-64  -I../sysdeps/ieee754 
-I../sysdeps/generic  -I.. -I../libio -I.   -D_LIBC_REENTRANT -include
/export/build/gnu/tools-build/glibc/build-x86_64-linux/libc-modules.h
-DMODULE_NAME=testsuite -include ../include/libc-symbols.h      
-DTOP_NAMESPACE=glibc -o
/export/build/gnu/tools-build/glibc/build-x86_64-linux/posix/test-errno.o -MD
-MP -MF
/export/build/gnu/tools-build/glibc/build-x86_64-linux/posix/test-errno.o.dt
-MT /export/build/gnu/tools-build/glibc/build-x86_64-linux/posix/test-errno.o

test-errno.c: In function ??do_test??:
test-errno.c:122:30: error: argument 1 value -1 is negative
[-Werror=stringop-overflow=]
  122 |   fails |= test_wrp (EINVAL, getgroups, -1, 0);
      |                              ^
test-errno.c:65:17: note: in definition of macro ??test_wrp_rv??
   65 |     rtype ret = syscall (__VA_ARGS__);    \
      |                 ^~~~~~~
test-errno.c:122:12: note: in expansion of macro ??test_wrp??
  122 |   fails |= test_wrp (EINVAL, getgroups, -1, 0);
      |            ^~~~~~~~
In file included from ../include/unistd.h:2,
                 from test-errno.c:35:
../posix/unistd.h:701:12: note: in a call to function ??getgroups?? declared
with attribute ??write_only (2, 1)??
  701 | extern int getgroups (int __size, __gid_t __list[]) __THROW __wur
      |            ^~~~~~~~~
test-errno.c:137:30: error: ??readlink?? specified size 18446744073709551615
exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
  137 |   fails |= test_wrp (EINVAL, readlink, "/", buf, -1);
      |                              ^
test-errno.c:65:17: note: in definition of macro ??test_wrp_rv??
   65 |     rtype ret = syscall (__VA_ARGS__);    \
      |                 ^~~~~~~
test-errno.c:137:12: note: in expansion of macro ??test_wrp??
  137 |   fails |= test_wrp (EINVAL, readlink, "/", buf, -1);
      |            ^~~~~~~~
In file included from ../include/unistd.h:2,
                 from test-errno.c:35:
../posix/unistd.h:820:16: note: in a call to function ??readlink?? declared
with attribute ??write_only (2, 3)??
  820 | extern ssize_t readlink (const char *__restrict __path,
      |                ^~~~~~~~
cc1: all warnings being treated as errors

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/25967] [2.32 regression] test-errno.c/tst-getcwd.c can't be compiled by GCC 10

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25967

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msebor at redhat dot com
            Summary|test-errno.c can't be       |[2.32 regression]
                   |compiled by GCC 10          |test-errno.c/tst-getcwd.c
                   |                            |can't be compiled by GCC 10

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
This is caused by

commit 06febd8c6705c816b2f32ee7aa1f4c0184b05248
Author: Martin Sebor <msebor@redhat.com>
Date:   Mon May 4 11:21:50 2020 -0600

    improve out-of-bounds checking with GCC 10 attribute access [BZ #25219]

    Adds the access attribute newly introduced in GCC 10 to the subset of
    function declarations that are already covered by _FORTIFY_SOURCE and
    that don't have corresponding GCC built-in equivalents.

    Reviewed-by: DJ Delorie <dj@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/25967] [2.32 regression] test-errno.c/tst-getcwd.c can't be compiled by GCC 10

[msebor at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25967

Martin Sebor <msebor at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msebor at gmail dot com

--- Comment #2 from Martin Sebor <msebor at gmail dot com> ---
A patch to fix the problems pointed out by the warnings is being discussed
here:
https://sourceware.org/pipermail/libc-alpha/2020-May/113686.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/25967] [2.32 regression] test-errno.c/tst-getcwd.c can't be compiled by GCC 10

[ppluzhnikov at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25967

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |ppluzhnikov at google dot com

--- Comment #3 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
Fixed by commit 978e8ac39f8ba2d694031e521511da1ae803ccfc

Author: Martin Sebor <msebor@redhat.com>
Date:   Mon May 11 11:29:39 2020 -0600

    Suppress GCC 10 true positive warnings [BZ #25967]

    Suppress or avoid warnings in tests that exercise failure modes by making
    calls with invalid arguments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.