[Bug libc/26053] New: unlockpt fails with ENOTTY for non-ptmx descriptors

[Bug libc/26053] New: unlockpt fails with ENOTTY for non-ptmx descriptors

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26053

            Bug ID: 26053
           Summary: unlockpt fails with ENOTTY for non-ptmx descriptors
           Product: glibc
           Version: 2.32
            Status: NEW
          Severity: minor
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: fweimer at redhat dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---
             Flags: security-

POSIX specifies an error code of EINVAL in this case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/26053] unlockpt fails with ENOTTY for non-ptmx descriptors

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26053

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at sourceware dot org   |fweimer at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/26053] unlockpt fails with ENOTTY for non-ptmx descriptors

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26053

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/26053] unlockpt fails with ENOTTY for non-ptmx descriptors

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26053

--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
Patch posted: https://sourceware.org/pipermail/libc-alpha/2020-May/114378.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/26053] unlockpt fails with ENOTTY for non-ptmx descriptors

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26053

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.33
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
Fixed for glibc 2.33:

commit 0f9793a556675d67d7c1897553f92e7152d1e598
Author: Florian Weimer <fweimer@redhat.com>
Date:   Wed Oct 7 10:48:10 2020 +0200

    Linux: unlockpt needs to fail with EINVAL, not ENOTTY (bug 26053)

    The EINVAL error code is mandated by POSIX and documented in the
    manual.  Also clean up the unlockpt implementation a bit, assuming
    that TIOCSPTLCK is always defined.

    Enhance login/tst-grantpt to cover unlockpt corner cases.

    Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.