[Bug nss/26258] New: nss_compat should not read input files with mmap

[Bug nss/26258] New: nss_compat should not read input files with mmap

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26258

            Bug ID: 26258
           Summary: nss_compat should not read input files with mmap
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nss
          Assignee: unassigned at sourceware dot org
          Reporter: fweimer at redhat dot com
  Target Milestone: ---

nss_compat opens its input files like this, requesting the use of mmap from
fopen:

      ent->stream = fopen ("/etc/group", "rme");

This may result in crashes if the files are truncated while reading.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nss/26258] nss_compat should not read input files with mmap

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26258

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |fweimer at redhat dot com
              Flags|                            |security-
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nss/26258] nss_compat should not read input files with mmap

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26258

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
Patch posted: https://sourceware.org/pipermail/libc-alpha/2020-July/116432.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nss/26258] nss_compat should not read input files with mmap

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26258

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |2.32

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
Fixed for glibc 2.32 via:

commit 23ed36735af09c258e542266aaed92cdd8571c6c
Author: Florian Weimer <fweimer@redhat.com>
Date:   Thu Jul 16 16:21:28 2020 +0200

    nss_compat: Do not use mmap to read database files (bug 26258)

    This avoids crashes in case the files are truncated for some reason.
    For typically file sizes, it is also going to be slightly faster.
    Using __nss_files_fopen instead mirrors what nss_files does.

    Tested-by: Carlos O'Donell <carlos@redhat.com>
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.