[Bug libc/26737] New: Random FAIL: rt/tst-shm

[Bug libc/26737] New: Random FAIL: rt/tst-shm

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26737

            Bug ID: 26737
           Summary: Random FAIL: rt/tst-shm
           Product: glibc
           Version: 2.33
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

On a heavy loaded machine with 112 cores, I got random:

FAIL: rt/tst-shm

[hjl@gnu-skx-1 build-x86_64-linux]$ cat rt/tst-shm.test-result
FAIL: rt/tst-shm
original exit status 1
[hjl@gnu-skx-1 build-x86_64-linux]$ cat rt/tst-shm.out 
[hjl@gnu-skx-1 build-x86_64-linux]$ 

It is not reproducible by hand.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/26737] Random FAIL: rt/tst-shm

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26737

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg

--- Comment #1 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
The shm_open for the test tries to open the same file regardless (usually
'/dev/shm/glibc-shm-test' but it can vary whether the shared memory path is
obtained) and it is opened with O_CREAT|O_EXCL. Maybe the test is being issued
concurrently by two glibc make check as same time?

I think we can try to create random filename to use with shm_open.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/26737] Random FAIL: rt/tst-shm

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26737

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Adhemerval Zanella from comment #1)
> The shm_open for the test tries to open the same file regardless (usually
> '/dev/shm/glibc-shm-test' but it can vary whether the shared memory path is
> obtained) and it is opened with O_CREAT|O_EXCL. Maybe the test is being
> issued concurrently by two glibc make check as same time?
>

3 glibc "make check" were running at the same time.

> I think we can try to create random filename to use with shm_open.

Shouldn't we append PID to /dev/shm/glibc-shm-test like tst-mqueue6.c?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/26737] Random FAIL: rt/tst-shm

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26737

--- Comment #3 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
(In reply to H.J. Lu from comment #2)
> (In reply to Adhemerval Zanella from comment #1)
> > The shm_open for the test tries to open the same file regardless (usually
> > '/dev/shm/glibc-shm-test' but it can vary whether the shared memory path is
> > obtained) and it is opened with O_CREAT|O_EXCL. Maybe the test is being
> > issued concurrently by two glibc make check as same time?
> >
> 
> 3 glibc "make check" were running at the same time.

I saw the same failure with 2 glibc for different architecture running on the
same system (for my case it was powerpc and powerpc64).

> 
> > I think we can try to create random filename to use with shm_open.
> 
> Shouldn't we append PID to /dev/shm/glibc-shm-test like tst-mqueue6.c?

I think this should be suffice to avoid this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/26737] Random FAIL: rt/tst-shm

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26737

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
tst-shm-cancel.c has the same issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/26737] Random FAIL: rt/tst-shm

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26737

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed by

commit 9030377480effce89f382499ff47a22467112436
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Oct 15 10:59:04 2020 -0700

    shm tests: Append PID to names passed to shm_open [BZ #26737]

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/26737] Random FAIL: rt/tst-shm

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26737

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.33
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.