[Bug glob/27522] New: glob, glob64 incorrectly marked as _THROW

[Bug glob/27522] New: glob, glob64 incorrectly marked as _THROW

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27522

            Bug ID: 27522
           Summary: glob, glob64 incorrectly marked as _THROW
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: glob
          Assignee: unassigned at sourceware dot org
          Reporter: fweimer at redhat dot com
  Target Milestone: ---
             Flags: security-

glob and glob64 are marked as _THROW, which implies they are leaf functions.
Due to the use of callbacks, that is not actually true, so they should be
declared with _THROWNL.

This results in a failure of posix/tst-glob_lstat_compat once the test is no
longer marked as internal.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug glob/27522] glob, glob64 incorrectly marked as _THROW

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27522

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
           Assignee|unassigned at sourceware dot org   |fweimer at redhat dot com
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug glob/27522] glob, glob64 incorrectly marked as __THROW

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27522

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|glob, glob64 incorrectly    |glob, glob64 incorrectly
                   |marked as _THROW            |marked as __THROW

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug glob/27522] glob, glob64 incorrectly marked as __THROW

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27522

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.34

--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
Fixed for glibc 2.34 via:

commit 3c667926673bac6017bf78569f582f6baee9948f
Author: Florian Weimer <fweimer@redhat.com>
Date:   Fri Mar 5 12:02:20 2021 +0100

    posix: glob, glob64 should not be declared __THROW [BZ #27522]

    These functions invoke callbacks with GLOB_ALTDIRFUNC, so they
    are not leaf functions (as implied by _THROW).  Use __THROWNL
    and __REDIRECT_NTHNL to express this.

    Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug glob/27522] glob, glob64 incorrectly marked as __THROW

[pinskia at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27522

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 28611 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.