[Bug build/27991] New: x86: sysdeps/x86/configure.ac breaks when libc_cv_include_x86_isa_level is loaded from cache

[Bug build/27991] New: x86: sysdeps/x86/configure.ac breaks when libc_cv_include_x86_isa_level is loaded from cache

[sourceware at mattwhitlock dot name]

https://sourceware.org/bugzilla/show_bug.cgi?id=27991

            Bug ID: 27991
           Summary: x86: sysdeps/x86/configure.ac breaks when
                    libc_cv_include_x86_isa_level is loaded from cache
           Product: glibc
           Version: 2.33
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: sourceware at mattwhitlock dot name
                CC: carlos at redhat dot com
  Target Milestone: ---

This bug is a follow-on to Bug 27318 Comment 10.

sysdeps/x86/configure.ac incorrectly makes one call to AC_CACHE_CHECK to set
three variables: libc_cv_include_x86_isa_level, libc_cv_have_x86_lahf_sahf, and
libc_cv_have_x86_movbe. This has the consequence that the latter two variables
do not get set whenever the first variable's value is loaded from cache. Then,
the later tests using those variables fail because the test arguments are
unquoted and the variables are unset.

Attached is a patch that refactors the checks for LAHF/SAHF and MOVBE
instruction support into separate AC_CACHE_CHECK calls so that the variables
are defined even when libc_cv_include_x86_isa_level is cached.

I will also submit the patch to the libc-alpha@sourceware.org list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/27991] x86: sysdeps/x86/configure.ac breaks when libc_cv_include_x86_isa_level is loaded from cache

[sourceware at mattwhitlock dot name]

https://sourceware.org/bugzilla/show_bug.cgi?id=27991

--- Comment #1 from Matt Whitlock <sourceware at mattwhitlock dot name> ---
Created attachment 13498
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13498&action=edit
patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/27991] x86: sysdeps/x86/configure.ac breaks when libc_cv_include_x86_isa_level is loaded from cache

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27991

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg
   Target Milestone|---                         |2.35
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
Fixed on 2.35.

-- 
You are receiving this mail because:
You are on the CC list for the bug.