[Bug string/28064] New: x86_64:wcslen implementation list has wcsnlen

[Bug string/28064] New: x86_64:wcslen implementation list has wcsnlen

[skpgkp2 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28064

            Bug ID: 28064
           Summary: x86_64:wcslen implementation list has wcsnlen
           Product: glibc
           Version: 2.34
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: string
          Assignee: unassigned at sourceware dot org
          Reporter: skpgkp2 at gmail dot com
                CC: goldstein.w.n at gmail dot com, hjl.tools at gmail dot com
  Target Milestone: ---
            Target: x86_64

This seems like a typo, test-wcslen implementation list has wcsnlen for SSE4_1,
as a result test-wcslen is failing. Further analysis point to following commit.

$ git show 6f573a27b6c8b4236445810a44660612323f5a73 ifunc-impl-list.c
commit 6f573a27b6c8b4236445810a44660612323f5a73
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Wed Jun 23 01:19:34 2021 -0400

    x86-64: Add wcslen optimize for sse4.1

    No bug. This comment adds the ifunc / build infrastructure
    necessary for wcslen to prefer the sse4.1 implementation
    in strlen-vec.S. test-wcslen.c is passing.

    Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c
b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
index 15eda47667..dbd1ebf298 100644
--- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c
+++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
@@ -684,6 +684,9 @@ __libc_ifunc_impl_list (const char *name, struct
libc_ifunc_impl *array,
                               && CPU_FEATURE_USABLE (AVX512BW)
                               && CPU_FEATURE_USABLE (BMI2)),
                              __wcslen_evex)
+             IFUNC_IMPL_ADD (array, i, wcsnlen,
+                             CPU_FEATURE_USABLE (SSE4_1),
+                             __wcsnlen_sse4_1)
              IFUNC_IMPL_ADD (array, i, wcslen, 1, __wcslen_sse2))

   /* Support sysdeps/x86_64/multiarch/wcsnlen.c.  */

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug string/28064] x86_64:wcslen implementation list has wcsnlen

[skpgkp2 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28064

Sunil Pandey <skpgkp2 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |skpgkp2 at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug string/28064] x86_64:wcslen implementation list has wcsnlen

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28064

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
This is a test-only bug, right? Thanks for reporting it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug string/28064] x86_64:wcslen implementation list has wcsnlen

[goldstein.w.n at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28064

--- Comment #2 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
I think this would be an actual bug on machines that would prefer sse4.1.

Currently testing a patch to fix this.

Not sure why it was passing test-wcslen.c in the first place. Sorry!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug string/28064] x86_64:wcslen implementation list has wcsnlen

[goldstein.w.n at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28064

--- Comment #3 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
Submitted a patch to fix this:

[PATCH v1] x86: Remove wcsnlen-sse4_1 from wcslen ifunc-impl-list [BZ #28064]

It's clearly a bug, though I was unable to reproduce it which makes me a bit
suspicious there is another issue with the commit(s) elsewhere.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug string/28064] x86_64:wcslen implementation list has wcsnlen

[goldstein.w.n at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28064

--- Comment #4 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
Pushed fix:

commit 0679442defedf7e52a94264975880ab8674736b2 (HEAD -> master)
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Thu Jul 8 16:13:19 2021 -0400

As well as test from H.J Lu

commit a6e7c3745d73ff876b4ba6991fb00768a938aef5
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Jul 8 16:13:17 2021 -0400

Closing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug string/28064] x86_64:wcslen implementation list has wcsnlen

[goldstein.w.n at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28064

--- Comment #5 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
(In reply to Noah Goldstein from comment #4)
> Pushed fix:
> 
> commit 0679442defedf7e52a94264975880ab8674736b2 (HEAD -> master)
> Author: Noah Goldstein <goldstein.w.n@gmail.com>
> Date:   Thu Jul 8 16:13:19 2021 -0400
> 
> As well as test from H.J Lu
> 
> commit a6e7c3745d73ff876b4ba6991fb00768a938aef5
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date:   Thu Jul 8 16:13:17 2021 -0400
> 
> Closing.

I apparently don't have permissions to close. So someone else will.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug string/28064] x86_64:wcslen implementation list has wcsnlen

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28064

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.34
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.