[Bug build/28089] New: tst-tls20 fails when linker defaults to --as-needed

[Bug build/28089] New: tst-tls20 fails when linker defaults to --as-needed

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28089

            Bug ID: 28089
           Summary: tst-tls20 fails when linker defaults to --as-needed
           Product: glibc
           Version: 2.34
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: michael.hudson at canonical dot com
                CC: carlos at redhat dot com
  Target Milestone: ---

Testing master on Ubuntu (devel release) elf/tst-tls20 fails with heaps of this
output:

error: tst-tls20.c:329: not true: moddep == 0

(and then the test eventually smashes the stack and crashes).

This turns out to be because all the elf/tst-tls-manydynamic*mod-dep-bad.so
shared objects are not in fact bad, because they do not DT_NEEDED the libraries
the tests assume them to:

(impish-amd64)root@anduril:/build/glibc-1BbEew/glibc-2.33.9000-916-gba33937be2/build-tree/amd64-libc#
readelf -d elf/tst-tls-manydynamic1mod-dep-bad.so | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [ld-linux-x86-64.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]

And this is because our linker defaults to --as-needed.

I think adding a bunch of lines of the form 

LDFLAGS-tls-manydynamic3mod-dep-bad.so += -Wl,--as-needed

will fix this, I don't know GNU make well enough to know if there's a way this
can be done without a line for each .so.

The tls-manydynamic*mod-dep.so libraries have the same issue, so I guess the
positive side tests of this functionality isn't actually testing very much on
my system either.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/28089] tst-tls20 fails when linker defaults to --as-needed

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28089

Michael Hudson-Doyle <michael.hudson at canonical dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hudson at canonical dot co
                   |                            |m

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/28089] tst-tls20 fails when linker defaults to --as-needed

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28089

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg
           Assignee|unassigned at sourceware dot org   |adhemerval.zanella at linaro dot o
                   |                            |rg
   Target Milestone|---                         |2.34
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
Fixed upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.