public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug dynamic-link/28154] New: [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld
@ 2021-07-28 21:15 i at maskray dot me
2021-07-29 22:21 ` [Bug dynamic-link/28154] " hjl.tools at gmail dot com
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: i at maskray dot me @ 2021-07-28 21:15 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28154
Bug ID: 28154
Summary: [test] sysdeps/x86/tst-ifunc-isa-* lazy binding
failure with ld.lld
Product: glibc
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: dynamic-link
Assignee: unassigned at sourceware dot org
Reporter: i at maskray dot me
Target Milestone: ---
Extracted from
https://sourceware.org/pipermail/libc-alpha/2021-July/129450.html
To build LLD 13.0.0:
# https://github.com/llvm/llvm-project/ origin/release/13.x
cmake -H. -Bout/release -G Ninja -DCMAKE_BUILD_TYPE=Release
-DLLVM_ENABLE_PROJECTS='clang;lld'
ninja -C out/release lld
I use
sudo ln -sf $PWD/out/release/bin/lld /usr/local/bin/ld
to ensure the glibc build system definitely picks ld => lld
(messing around with LDFLAGS=-fuse-ld=lld may work as well)
`make check` says sysdeps/x86/tst-ifunc-isa-* fail.
The tests work with LD_BIND_NOW=1.
I debugged a bit. ld.lld and GNU ld place IRELATIVE differently. IIUC some
ports of GNU ld use .rela.dyn and behave similar to ld.lld.
The tests happen to work with GNU ld because the IRELATIVE for foo_ifunc
is placed after JUMP_SLOT in .repa.plt. The test needs to call
__x86_get_cpuid_feature_leaf which is defined in a different TU. IMHO
such ifunc does not guaranteed to work.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug dynamic-link/28154] [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld
2021-07-28 21:15 [Bug dynamic-link/28154] New: [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld i at maskray dot me
@ 2021-07-29 22:21 ` hjl.tools at gmail dot com
2021-07-29 22:54 ` i at maskray dot me
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: hjl.tools at gmail dot com @ 2021-07-29 22:21 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28154
H.J. Lu <hjl.tools at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hjl.tools at gmail dot com
--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
See PR ld/13302. lld should implement the same behavior.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug dynamic-link/28154] [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld
2021-07-28 21:15 [Bug dynamic-link/28154] New: [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld i at maskray dot me
2021-07-29 22:21 ` [Bug dynamic-link/28154] " hjl.tools at gmail dot com
@ 2021-07-29 22:54 ` i at maskray dot me
2021-07-29 23:07 ` hjl.tools at gmail dot com
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: i at maskray dot me @ 2021-07-29 22:54 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28154
Fangrui Song <i at maskray dot me> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |amodra at gmail dot com
--- Comment #2 from Fangrui Song <i at maskray dot me> ---
(In reply to H.J. Lu from comment #1)
> See PR ld/13302. lld should implement the same behavior.
I think the GNU ld PowerPC (ld.lld) behavior (IRELATIVE in .rela.dyn) makes
more sense. IRELATIVE relocations are eagerly resolved, so .rela.dyn is better
than .rela.plt . .rela.plt should only have JUMP_SLOT.
To make PR ld/13302 work, ld.so can pause at IRELATIVE in .rela.dyn and start
applying .rela.plt
(I use the section names for simplicity. Impl should use dynamic tags
DT_RELA/DT_JMPREL.)
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug dynamic-link/28154] [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld
2021-07-28 21:15 [Bug dynamic-link/28154] New: [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld i at maskray dot me
2021-07-29 22:21 ` [Bug dynamic-link/28154] " hjl.tools at gmail dot com
2021-07-29 22:54 ` i at maskray dot me
@ 2021-07-29 23:07 ` hjl.tools at gmail dot com
2021-09-01 5:43 ` cvs-commit at gcc dot gnu.org
2024-04-24 7:10 ` amodra at gmail dot com
4 siblings, 0 replies; 6+ messages in thread
From: hjl.tools at gmail dot com @ 2021-07-29 23:07 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28154
--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Fangrui Song from comment #2)
>
> To make PR ld/13302 work, ld.so can pause at IRELATIVE in .rela.dyn and
> start applying .rela.plt
>
This requires both linker and ld.so changes. The PR ld/13302 linker change
doesn't require ld.so change.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug dynamic-link/28154] [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld
2021-07-28 21:15 [Bug dynamic-link/28154] New: [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld i at maskray dot me
` (2 preceding siblings ...)
2021-07-29 23:07 ` hjl.tools at gmail dot com
@ 2021-09-01 5:43 ` cvs-commit at gcc dot gnu.org
2024-04-24 7:10 ` amodra at gmail dot com
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-09-01 5:43 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28154
--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Fangrui Song <maskray@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=224edada607ebc6aaa1aadaae423128fae7880df
commit 224edada607ebc6aaa1aadaae423128fae7880df
Author: Fangrui Song <maskray@google.com>
Date: Mon Aug 30 13:59:33 2021 -0700
configure: Allow LD to be LLD 13.0.0 or above [BZ #26558]
When using LLD (LLVM linker) as the linker, configure prints a confusing
message.
*** These critical programs are missing or too old: GNU ld
LLD>=13.0.0 can build glibc --enable-static-pie. (8.0.0 needs one
workaround for -Wl,-defsym=_begin=0. 9.0.0 works with
--disable-static-pie).
XFAIL two tests sysdeps/x86/tst-ifunc-isa-* which have the BZ #28154
issue (LLD follows the PowerPC port of GNU ld for ifunc by placing
IRELATIVE relocations in .rela.dyn, triggering a glibc ifunc fragility).
The set of dynamic symbols is the same with GNU ld and LLD,
modulo unused SHN_ABS version node symbols.
For comparison, gold does not support --enable-static-pie
yet (--no-dynamic-linker is unsupported BZ #22221), yet
has 6 failures more than LLD. gold linked libc.so has
larger .dynsym differences with GNU ld and LLD
(non-default version symbols are changed to default versions
by a version script BZ #28196).
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug dynamic-link/28154] [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld
2021-07-28 21:15 [Bug dynamic-link/28154] New: [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld i at maskray dot me
` (3 preceding siblings ...)
2021-09-01 5:43 ` cvs-commit at gcc dot gnu.org
@ 2024-04-24 7:10 ` amodra at gmail dot com
4 siblings, 0 replies; 6+ messages in thread
From: amodra at gmail dot com @ 2024-04-24 7:10 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28154
Alan Modra <amodra at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|amodra at gmail dot com |
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-24 7:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 21:15 [Bug dynamic-link/28154] New: [test] sysdeps/x86/tst-ifunc-isa-* lazy binding failure with ld.lld i at maskray dot me
2021-07-29 22:21 ` [Bug dynamic-link/28154] " hjl.tools at gmail dot com
2021-07-29 22:54 ` i at maskray dot me
2021-07-29 23:07 ` hjl.tools at gmail dot com
2021-09-01 5:43 ` cvs-commit at gcc dot gnu.org
2024-04-24 7:10 ` amodra at gmail dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).