public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/28223] New: mips: clone does not align stack
@ 2021-08-12 16:37 xry111 at mengyan1223 dot wang
  2021-08-12 20:32 ` [Bug libc/28223] " cvs-commit at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: xry111 at mengyan1223 dot wang @ 2021-08-12 16:37 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28223

            Bug ID: 28223
           Summary: mips: clone does not align stack
           Product: glibc
           Version: 2.35
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: xry111 at mengyan1223 dot wang
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

On MIPS, with O32 ABI clone should align stack to 4 bytes, and with N32/N64 ABI
clone should align stack to 8 bytes.

This causes:

FAIL: misc/tst-misalign-clone

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libc/28223] mips: clone does not align stack
  2021-08-12 16:37 [Bug libc/28223] New: mips: clone does not align stack xry111 at mengyan1223 dot wang
@ 2021-08-12 20:32 ` cvs-commit at gcc dot gnu.org
  2021-08-12 20:34 ` jsm28 at gcc dot gnu.org
  2021-12-14 22:18 ` cvs-commit at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-08-12 20:32 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28223

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Joseph Myers <jsm28@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe

commit 1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe
Author: Xi Ruoyao <xry111@mengyan1223.wang>
Date:   Thu Aug 12 20:31:59 2021 +0000

    mips: align stack in clone [BZ #28223]

    The MIPS O32 ABI requires 4 byte aligned stack, and the MIPS N64 and N32
    ABI require 8 byte aligned stack.  Previously if the caller passed an
    unaligned stack to clone the the child misbehaved.

    Fixes bug 28223.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libc/28223] mips: clone does not align stack
  2021-08-12 16:37 [Bug libc/28223] New: mips: clone does not align stack xry111 at mengyan1223 dot wang
  2021-08-12 20:32 ` [Bug libc/28223] " cvs-commit at gcc dot gnu.org
@ 2021-08-12 20:34 ` jsm28 at gcc dot gnu.org
  2021-12-14 22:18 ` cvs-commit at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2021-08-12 20:34 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28223

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.35
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.35.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libc/28223] mips: clone does not align stack
  2021-08-12 16:37 [Bug libc/28223] New: mips: clone does not align stack xry111 at mengyan1223 dot wang
  2021-08-12 20:32 ` [Bug libc/28223] " cvs-commit at gcc dot gnu.org
  2021-08-12 20:34 ` jsm28 at gcc dot gnu.org
@ 2021-12-14 22:18 ` cvs-commit at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-12-14 22:18 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28223

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The release/2.34/master branch has been updated by Aurelien Jarno
<aurel32@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7af07fe795f43e53d31be1c6f9adba7e05f87b0b

commit 7af07fe795f43e53d31be1c6f9adba7e05f87b0b
Author: Xi Ruoyao <xry111@mengyan1223.wang>
Date:   Thu Aug 12 20:31:59 2021 +0000

    mips: align stack in clone [BZ #28223]

    The MIPS O32 ABI requires 4 byte aligned stack, and the MIPS N64 and N32
    ABI require 8 byte aligned stack.  Previously if the caller passed an
    unaligned stack to clone the the child misbehaved.

    Fixes bug 28223.

    (cherry picked from commit 1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-14 22:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-12 16:37 [Bug libc/28223] New: mips: clone does not align stack xry111 at mengyan1223 dot wang
2021-08-12 20:32 ` [Bug libc/28223] " cvs-commit at gcc dot gnu.org
2021-08-12 20:34 ` jsm28 at gcc dot gnu.org
2021-12-14 22:18 ` cvs-commit at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).