[Bug dynamic-link/28455] New: -Wl,--enable-new-dtags doesn't work

[Bug dynamic-link/28455] New: -Wl,--enable-new-dtags doesn't work

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

            Bug ID: 28455
           Summary: -Wl,--enable-new-dtags doesn't work
           Product: glibc
           Version: 2.34
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dynamic-link
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
  Target Milestone: ---

On Linux/x86-64, use -Wl,--enable-new-dtags to build glibc causes

FAIL: dlfcn/bug-dl-leaf
FAIL: elf/constload1
FAIL: elf/global
FAIL: elf/tst-audit10
FAIL: elf/tst-audit11
FAIL: elf/tst-audit12
FAIL: elf/tst-audit14-cmp
FAIL: elf/tst-audit15-cmp
FAIL: elf/tst-audit16-cmp
FAIL: elf/tst-audit4
FAIL: elf/tst-audit5
FAIL: elf/tst-audit6
FAIL: elf/tst-audit7
FAIL: elf/tst-dlmopen-dlerror
FAIL: elf/tst-dlmopen-gethostbyname
FAIL: elf/tst-dlmopen1
FAIL: elf/tst-dlmopen3
FAIL: elf/tst-dlmopen4
FAIL: elf/tst-dlopen-nodelete-reloc
FAIL: elf/tst-nodelete-dlclose
FAIL: elf/tst-single_threaded
FAIL: elf/tst-single_threaded-pthread
FAIL: elf/tst-sonamemove-dlopen
FAIL: elf/tst-sonamemove-link
FAIL: elf/tst-tls-ie-dlmopen
FAIL: elf/unload6
FAIL: nss/tst-nss-test1
FAIL: nss/tst-nss-test2
FAIL: nss/tst-nss-test4
FAIL: nss/tst-nss-test5

It looks like that DT_RUNPATH isn't properly handled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28455] -Wl,--enable-new-dtags doesn't work

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
The difference between DT_RPATH and DT_RUNPATH is that

1. Directories specified by DT_RPATH are searched before directories specified
by LD_LIBRARY_PATH.
2. Directories specified by DT_RUNPATH are searched after directories specified
by LD_LIBRARY_PATH.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28455] -Wl,--enable-new-dtags doesn't work

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
It looks like a --enable-hardcoded-path-in-tests issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28455] -Wl,--enable-new-dtags doesn't work

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
DT_AUDIT ignores DT_RUNPATH.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28455] -Wl,--enable-new-dtags doesn't work

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |skpgkp2 at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28455] -Wl,--enable-new-dtags doesn't work

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
It happens on Fedora 34/35 since linker defaults to --enable-new-dtags.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28455] -Wl,--enable-new-dtags doesn't work

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28455] -Wl,--enable-new-dtags doesn't work

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=57e349b1b0df1aee2dcd19dae1f324bde25ff8f0

commit 57e349b1b0df1aee2dcd19dae1f324bde25ff8f0
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Dec 8 07:02:27 2021 -0800

    Disable DT_RUNPATH on NSS tests [BZ #28455]

    The glibc internal NSS functions should always load NSS modules from
    the system.  For testing purpose, disable DT_RUNPATH on NSS tests so
    that the glibc internal NSS functions can load testing NSS modules
    via DT_RPATH.

    This partially fixes BZ #28455.

    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28455] -Wl,--enable-new-dtags doesn't work

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com,
                   |                            |hjl.tools at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28455] -Wl,--enable-new-dtags doesn't work

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bfb5ed5df3dd4d9507b4922248dc445b690d19c0

commit bfb5ed5df3dd4d9507b4922248dc445b690d19c0
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Oct 15 10:44:49 2021 -0700

    elf: Also try DT_RUNPATH for LD_AUDIT dlopen [BZ #28455]

    DT_RUNPATH is only used to find the immediate dependencies of the
    executable or shared object containing the DT_RUNPATH entry.  Update
    LD_AUDIT dlopen call to try the DT_RUNPATH entry of the executable.

    Add tst-audit14a, which is copied from tst-audit14, to DT_RUNPATH and
    build tst-audit14 with -Wl,--disable-new-dtags to test DT_RPATH.

    This partially fixes BZ #28455.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28455] -Wl,--enable-new-dtags doesn't work

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=114d07fd9a54684cb67b02174f2c48d19f3e2502

commit 114d07fd9a54684cb67b02174f2c48d19f3e2502
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Oct 15 06:33:05 2021 -0700

    Add and use link-test-modules-rpath-link [BZ #28455]

    DT_RUNPATH is only used to find the immediate dependencies of the
    executable or shared object containing the DT_RUNPATH entry:

    1. Define link-test-modules-rpath-link if $(build-hardcoded-path-in-tests)
    is yes.
    2. Use $(link-test-modules-rpath-link) in build-module-helper so that
    test modules can dlopen modules with DT_RUNPATH.
    3. Add a test to show why link-test-modules-rpath-link is needed.

    This partially fixes BZ #28455.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28455] -Wl,--enable-new-dtags doesn't work

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28455

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.35

--- Comment #8 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for 2.35.

-- 
You are receiving this mail because:
You are on the CC list for the bug.