public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "msc at linux dot ibm.com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/28532] powerpc64[le]: CFI for assembly templated syscalls is incorrect
Date: Fri, 17 Dec 2021 20:24:59 +0000	[thread overview]
Message-ID: <bug-28532-131-KsjnzFzrON@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28532-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28532

Matheus Castanho <msc at linux dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #4 from Matheus Castanho <msc at linux dot ibm.com> ---
New failing tests are now fixed by:

commit ae91d3df24a4a1b1f264d101a71a298bff310d14
Author: Matheus Castanho <msc@linux.ibm.com>
Date:   Wed Dec 1 11:14:40 2021 -0300

    powerpc64[le]: Allocate extra stack frame on syscall.S

    The syscall function does not allocate the extra stack frame for scv like
other
    assembly syscalls using DO_CALL_SCV. So after commit d120fb9941 changed the
    offset that is used to save LR, syscall ended up using an invalid offset,
    causing regressions on powerpc64. So make sure the extra stack frame is
    allocated in syscall.S as well to make it consistent with other uses of
    DO_CALL_SCV and avoid similar issues in the future.

    Tested on powerpc, powerpc64, and powerpc64le (with and without scv)

    Reviewed-by: Raphael M Zinsly <rzinsly@linux.ibm.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2021-12-17 20:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 14:07 [Bug libc/28532] New: " msc at linux dot ibm.com
2021-11-03 14:07 ` [Bug libc/28532] " msc at linux dot ibm.com
2021-11-23 17:38 ` schwab@linux-m68k.org
2021-11-30 18:28 ` msc at linux dot ibm.com
2021-12-01 19:14 ` msc at linux dot ibm.com
2021-12-17 20:24 ` msc at linux dot ibm.com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28532-131-KsjnzFzrON@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).