public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug dynamic-link/28550] New: FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
@ 2021-11-05 13:34 hjl.tools at gmail dot com
2021-11-06 14:54 ` [Bug dynamic-link/28550] " hjl.tools at gmail dot com
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: hjl.tools at gmail dot com @ 2021-11-05 13:34 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28550
Bug ID: 28550
Summary: FAIL:
tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.
dynamic_sort=1) execution test
Product: glibc
Version: 2.35
Status: NEW
Severity: normal
Priority: P2
Component: dynamic-link
Assignee: unassigned at sourceware dot org
Reporter: hjl.tools at gmail dot com
CC: cltang at codesourcery dot com
Target Milestone: ---
The new dso-sort-tests-1 fails for different reasons at random on
many-core machine with load. elf/Makefile has
# DSO sorting tests:
# The dso-ordering-test.py script generates testcase source files in $(objpfx),
# creating a $(objpfx)<testcase-name>-dir for each testcase, and creates a
# Makefile fragment to be included.
define include_dsosort_tests
$(objpfx)$(1).generated-makefile: $(1)
$(PYTHON) $(..)scripts/dso-ordering-test.py \
--description-file $$< --objpfx $(objpfx) --output-makefile $$@
include $(objpfx)$(1).generated-makefile
endef
# Generate from each testcase description file
ifeq (yes,$(have-tunables))
$(eval $(call include_dsosort_tests,dso-sort-tests-1.def))
$(eval $(call include_dsosort_tests,dso-sort-tests-2.def))
endif
I don't think it works well with parallel build on many-core machines.
I think it should be changed to use configure.ac or Makeconfig to generate
these makefile fragments.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug dynamic-link/28550] FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
2021-11-05 13:34 [Bug dynamic-link/28550] New: FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test hjl.tools at gmail dot com
@ 2021-11-06 14:54 ` hjl.tools at gmail dot com
2021-11-06 18:10 ` hjl.tools at gmail dot com
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: hjl.tools at gmail dot com @ 2021-11-06 14:54 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28550
--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
elf/Makefile has
extra-test-objs += $(addsuffix .os,$(strip $(modules-names)))
But the new test were added after it. Is this intentional?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug dynamic-link/28550] FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
2021-11-05 13:34 [Bug dynamic-link/28550] New: FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test hjl.tools at gmail dot com
2021-11-06 14:54 ` [Bug dynamic-link/28550] " hjl.tools at gmail dot com
@ 2021-11-06 18:10 ` hjl.tools at gmail dot com
2021-11-06 23:16 ` hjl.tools at gmail dot com
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: hjl.tools at gmail dot com @ 2021-11-06 18:10 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28550
--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
Another problem is in
# This is a funny rule in that it removes its input file.
%.d: %.dt
@sed $(sed-remove-objpfx) $< > $(@:.d=.T) && \
mv -f $(@:.d=.T) $@ && \
rm -f $<
When there are many dependencies with make -j50, the same .d file may be
generated in parallel. There may be a race condition since the input file
is removed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug dynamic-link/28550] FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
2021-11-05 13:34 [Bug dynamic-link/28550] New: FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test hjl.tools at gmail dot com
2021-11-06 14:54 ` [Bug dynamic-link/28550] " hjl.tools at gmail dot com
2021-11-06 18:10 ` hjl.tools at gmail dot com
@ 2021-11-06 23:16 ` hjl.tools at gmail dot com
2021-11-15 19:54 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: hjl.tools at gmail dot com @ 2021-11-06 23:16 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28550
--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
I also see:
make[4]: Circular
/export/users/hjl/build/gnu/tools-build/glibc-32bit-cet-gitlab/build-i686-linux/elf/tst-dso-ordering9-dir/tst-dso-ordering9_106-ebcda-d.so
<-
/export/users/hjl/build/gnu/tools-build/glibc-32bit-cet-gitlab/build-i686-linux/elf/tst-dso-ordering9-dir/tst-dso-ordering9_106-ebcda-e.so
dependency dropped.
make[4]: Circular
/export/users/hjl/build/gnu/tools-build/glibc-32bit-cet-gitlab/build-i686-linux/elf/tst-dso-ordering9-dir/tst-dso-ordering9_106-ebcda-e.so
<-
/export/users/hjl/build/gnu/tools-build/glibc-32bit-cet-gitlab/build-i686-linux/elf/tst-dso-ordering9-dir/tst-dso-ordering9_106-ebcda-e.so
dependency dropped.
make[4]: Circular
/export/users/hjl/build/gnu/tools-build/glibc-32bit-cet-gitlab/build-i686-linux/elf/tst-redhat-1162810-dir/tst-redhat-1162810-A104.os
<-
/export/users/hjl/build/gnu/tools-build/glibc-32bit-cet-gitlab/build-i686-linux/elf/tst-redhat-1162810-dir/tst-redhat-1162810-A192.so
dependency dropped.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug dynamic-link/28550] FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
2021-11-05 13:34 [Bug dynamic-link/28550] New: FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test hjl.tools at gmail dot com
` (2 preceding siblings ...)
2021-11-06 23:16 ` hjl.tools at gmail dot com
@ 2021-11-15 19:54 ` cvs-commit at gcc dot gnu.org
2021-11-16 13:18 ` cvs-commit at gcc dot gnu.org
2021-11-16 13:19 ` hjl.tools at gmail dot com
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-15 19:54 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28550
--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b4bbedb1e75737a80bcc3d53d6eef1fbe0b5f4d5
commit b4bbedb1e75737a80bcc3d53d6eef1fbe0b5f4d5
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Sat Nov 6 14:13:27 2021 -0700
dso-ordering-test.py: Put all sources in one directory [BZ #28550]
Put all sources for DSO sorting tests in the dso-sort-tests-src directory
and compile test relocatable objects with
$(objpfx)tst-dso-ordering1-dir/tst-dso-ordering1-a.os:
$(objpfx)dso-sort-tests-src/tst-dso-ordering1-a.c
$(compile.c) $(OUTPUT_OPTION)
to avoid random $< values from $(before-compile) when compiling test
relocatable objects with
$(objpfx)%$o: $(objpfx)%.c $(before-compile); $$(compile-command.c)
compile-command.c = $(compile.c) $(OUTPUT_OPTION) $(compile-mkdep-flags)
compile.c = $(CC) $< -c $(CFLAGS) $(CPPFLAGS)
for 3 "make -j 28" parallel builds on a machine with 112 cores at the
same time.
This partially fixes BZ #28550.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug dynamic-link/28550] FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
2021-11-05 13:34 [Bug dynamic-link/28550] New: FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test hjl.tools at gmail dot com
` (3 preceding siblings ...)
2021-11-15 19:54 ` cvs-commit at gcc dot gnu.org
@ 2021-11-16 13:18 ` cvs-commit at gcc dot gnu.org
2021-11-16 13:19 ` hjl.tools at gmail dot com
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-16 13:18 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28550
--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1f67d8286b5da9266a138198ef1f15c27cbb0010
commit 1f67d8286b5da9266a138198ef1f15c27cbb0010
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Mon Nov 15 16:28:39 2021 -0800
elf: Use a temporary file to generate Makefile fragments [BZ #28550]
1. Use a temporary file to generate Makefile fragments for DSO sorting
tests and use -include on them.
2. Add Makefile fragments to postclean-generated so that a "make clean"
removes the autogenerated fragments and a subsequent "make" regenerates
them.
This partially fixes BZ #28550.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug dynamic-link/28550] FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
2021-11-05 13:34 [Bug dynamic-link/28550] New: FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test hjl.tools at gmail dot com
` (4 preceding siblings ...)
2021-11-16 13:18 ` cvs-commit at gcc dot gnu.org
@ 2021-11-16 13:19 ` hjl.tools at gmail dot com
5 siblings, 0 replies; 7+ messages in thread
From: hjl.tools at gmail dot com @ 2021-11-16 13:19 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28550
H.J. Lu <hjl.tools at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
Target Milestone|--- |2.35
--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-11-16 13:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 13:34 [Bug dynamic-link/28550] New: FAIL: tst-dso-ordering9_112-ecbda(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test hjl.tools at gmail dot com
2021-11-06 14:54 ` [Bug dynamic-link/28550] " hjl.tools at gmail dot com
2021-11-06 18:10 ` hjl.tools at gmail dot com
2021-11-06 23:16 ` hjl.tools at gmail dot com
2021-11-15 19:54 ` cvs-commit at gcc dot gnu.org
2021-11-16 13:18 ` cvs-commit at gcc dot gnu.org
2021-11-16 13:19 ` hjl.tools at gmail dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).