public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/28702] New: RISC-V: clone does not align stack
@ 2021-12-15 23:03 aurelien at aurel32 dot net
  2021-12-17 19:30 ` [Bug libc/28702] " cvs-commit at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: aurelien at aurel32 dot net @ 2021-12-15 23:03 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28702

            Bug ID: 28702
           Summary: RISC-V: clone does not align stack
           Product: glibc
           Version: 2.35
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: aurelien at aurel32 dot net
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

On RISC-V clone should align the stack to 128 bits or 16 bytes as per RISC-V
ABI [1].

This is detected by:

FAIL: misc/tst-misalign-clone
FAIL: misc/tst-misalign-clone-internal


[1] https://github.com/riscv-non-isa/riscv-elf-psabi-doc

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libc/28702] RISC-V: clone does not align stack
  2021-12-15 23:03 [Bug libc/28702] New: RISC-V: clone does not align stack aurelien at aurel32 dot net
@ 2021-12-17 19:30 ` cvs-commit at gcc dot gnu.org
  2021-12-17 19:30 ` aurelien at aurel32 dot net
  2021-12-17 21:49 ` cvs-commit at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-12-17 19:30 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28702

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Aurelien Jarno <aurel32@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d2e594d71509faf36cf851a69370db34a4f5fa65

commit d2e594d71509faf36cf851a69370db34a4f5fa65
Author: Aurelien Jarno <aurelien@aurel32.net>
Date:   Tue Dec 14 22:44:35 2021 +0100

    riscv: align stack in clone [BZ #28702]

    The RISC-V ABI [1] mandates that "the stack pointer shall be aligned to
    a 128-bit boundary upon procedure entry". This as not the case in clone.

    This fixes the misc/tst-misalign-clone-internal and
    misc/tst-misalign-clone tests.

    Fixes bug 28702.

    [1] https://github.com/riscv-non-isa/riscv-elf-psabi-doc

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libc/28702] RISC-V: clone does not align stack
  2021-12-15 23:03 [Bug libc/28702] New: RISC-V: clone does not align stack aurelien at aurel32 dot net
  2021-12-17 19:30 ` [Bug libc/28702] " cvs-commit at gcc dot gnu.org
@ 2021-12-17 19:30 ` aurelien at aurel32 dot net
  2021-12-17 21:49 ` cvs-commit at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: aurelien at aurel32 dot net @ 2021-12-17 19:30 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28702

Aurelien Jarno <aurelien at aurel32 dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Aurelien Jarno <aurelien at aurel32 dot net> ---
Fixed in 2.35.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libc/28702] RISC-V: clone does not align stack
  2021-12-15 23:03 [Bug libc/28702] New: RISC-V: clone does not align stack aurelien at aurel32 dot net
  2021-12-17 19:30 ` [Bug libc/28702] " cvs-commit at gcc dot gnu.org
  2021-12-17 19:30 ` aurelien at aurel32 dot net
@ 2021-12-17 21:49 ` cvs-commit at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-12-17 21:49 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28702

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The release/2.34/master branch has been updated by Aurelien Jarno
<aurel32@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9de8011c328021f10588a8acb418daf5121d5f3d

commit 9de8011c328021f10588a8acb418daf5121d5f3d
Author: Aurelien Jarno <aurelien@aurel32.net>
Date:   Tue Dec 14 22:44:35 2021 +0100

    riscv: align stack in clone [BZ #28702]

    The RISC-V ABI [1] mandates that "the stack pointer shall be aligned to
    a 128-bit boundary upon procedure entry". This as not the case in clone.

    This fixes the misc/tst-misalign-clone-internal and
    misc/tst-misalign-clone tests.

    Fixes bug 28702.

    [1] https://github.com/riscv-non-isa/riscv-elf-psabi-doc

    (cherry picked from commit d2e594d71509faf36cf851a69370db34a4f5fa65)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-17 21:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 23:03 [Bug libc/28702] New: RISC-V: clone does not align stack aurelien at aurel32 dot net
2021-12-17 19:30 ` [Bug libc/28702] " cvs-commit at gcc dot gnu.org
2021-12-17 19:30 ` aurelien at aurel32 dot net
2021-12-17 21:49 ` cvs-commit at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).