[Bug dynamic-link/28732] New: FAIL: elf/tst-dl_find_object

[Bug dynamic-link/28732] New: FAIL: elf/tst-dl_find_object

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28732

            Bug ID: 28732
           Summary: FAIL: elf/tst-dl_find_object
           Product: glibc
           Version: 2.35
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dynamic-link
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
                CC: fweimer at redhat dot com
  Target Milestone: ---

On Fedora 35, I got

FAIL: elf/tst-dl_find_object

$ cat elf/tst-dl_find_object.out 
info: main program unwind data: 0x7f7483b8ed90 (0)
tst-dl_find_object.c:151: error: 0x7f7483b89000: map end is 0x7f7483b8ac30,
expected 0x7f7483b91210
tst-dl_find_object.c:151: error: 0x7f7483b89000: map end is 0x7f7483b8ac30,
expected 0x7f7483b91210
tst-dl_find_object.c:151: error: 0x7f7483b89000: map end is 0x7f7483b8ac30,
expected 0x7f7483b91210
tst-dl_find_object.c:151: error: 0x7f7483b89000: map end is 0x7f7483b8ac30,
expected 0x7f7483b91210
tst-dl_find_object.c:151: error: 0x7f7483b89000: map end is 0x7f7483b8ac30,
expected 0x7f7483b91210
tst-dl_find_object.c:151: error: 0x7f7483b89000: map end is 0x7f7483b8ac30,
expected 0x7f7483b91210
error: 6 test failures

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28732] FAIL: elf/tst-dl_find_object

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28732

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
--enable-hardcoded-path-in-tests is needed to trigger failure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28732] FAIL: elf/tst-dl_find_object

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28732

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |fweimer at redhat dot com
             Status|NEW                         |ASSIGNED

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
There are two bugs here:

The dynamic linker does not set l_contiguous for the main executable if it has
been mapped by the kernel, even if the executable is contiguous in memory.

The test case does not disable its map start/map end checks for !l_contiguous
maps.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28732] FAIL: elf/tst-dl_find_object

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28732

--- Comment #3 from Florian Weimer <fweimer at redhat dot com> ---
ld creates executables with holes:

ELF LOAD segments creating holes in the process image on GNU/Linux
https://sourceware.org/pipermail/binutils/2022-January/119082.html

So it looks to me that for now, we only can adjust the test expectations.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28732] FAIL: elf/tst-dl_find_object

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28732

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=28743
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28732] FAIL: elf/tst-dl_find_object

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28732

--- Comment #4 from Florian Weimer <fweimer at redhat dot com> ---
Patches posted:

[PATCH 0/3] Fix elf/tst-dl_find_objects with --enable-hardcoded-path-in-tests
https://sourceware.org/pipermail/libc-alpha/2022-January/134892.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/28732] FAIL: elf/tst-dl_find_object

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28732

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.35

--- Comment #5 from Florian Weimer <fweimer at redhat dot com> ---
Fixed for glibc 2.35 via:

commit 06200aac9bec34dbcac28b8c60e49a77e7851c1f
Author: Florian Weimer <fweimer@redhat.com>
Date:   Mon Jan 17 09:57:19 2022 +0100

    elf/tst-dl_find_object: Disable subtests for non-contiguous maps (bug
28732)

    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

commit 8eb2510d38226ce10a3a15109be948f052585106
Author: Florian Weimer <fweimer@redhat.com>
Date:   Mon Jan 17 09:57:19 2022 +0100

    elf: Set l_contiguous to 1 for the main map in more cases

    l_contiguous was not initialized at all for the main map and
    always 0.  This commit adds code to check if the LOAD segments
    are adjacent to each other, and sets l_contiguous accordingly.
    This helps _dl_find_object because it is more efficient if the
    main mapping is contiguous.

    Note that not all (PIE or non-PIE) binaries are contiguous in this
    way because BFD ld creates executables with LOAD holes:

    ELF LOAD segments creating holes in the process image on GNU/Linux
    https://sourceware.org/pipermail/binutils/2022-January/119082.html
    https://sourceware.org/bugzilla/show_bug.cgi?id=28743

    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

commit b4d4ff8963866367ba861681ef3b1251e122014a
Author: Florian Weimer <fweimer@redhat.com>
Date:   Mon Jan 17 09:57:19 2022 +0100

    elf: Introduce rtld_setup_main_map

    This function collects most of the processing needed to initialize
    the link map for the main executable.

    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.