public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "siddhesh at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/28815] New: realpath should not copy to resolved buffer on error
Date: Mon, 24 Jan 2022 16:22:03 +0000	[thread overview]
Message-ID: <bug-28815-131@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=28815

            Bug ID: 28815
           Summary: realpath should not copy to resolved buffer on error
           Product: glibc
           Version: 2.35
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: siddhesh at sourceware dot org
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

If realpath fails and the "resolved" argument of the call is non-NULL, the
contents of the "resolved" are undefined.  The glibc implementation however
copies the contents into the buffer regardless of failure and even tests for
them in test-canon.c

The string copy should be avoided on error and the test should be adjusted to
not compare buffer contents on failure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2022-01-24 16:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 16:22 siddhesh at sourceware dot org [this message]
2022-02-21  2:58 ` [Bug libc/28815] " cvs-commit at gcc dot gnu.org
2022-02-21  2:59 ` siddhesh at sourceware dot org
2022-04-12 13:28 ` fweimer at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28815-131@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).