[Bug libc/28815] New: realpath should not copy to resolved buffer on error

[Bug libc/28815] New: realpath should not copy to resolved buffer on error

[siddhesh at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28815

            Bug ID: 28815
           Summary: realpath should not copy to resolved buffer on error
           Product: glibc
           Version: 2.35
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: siddhesh at sourceware dot org
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

If realpath fails and the "resolved" argument of the call is non-NULL, the
contents of the "resolved" are undefined.  The glibc implementation however
copies the contents into the buffer regardless of failure and even tests for
them in test-canon.c

The string copy should be avoided on error and the test should be adjusted to
not compare buffer contents on failure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/28815] realpath should not copy to resolved buffer on error

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28815

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Siddhesh Poyarekar
<siddhesh@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=949ad78a189194048df8a253bb31d1d11d919044

commit 949ad78a189194048df8a253bb31d1d11d919044
Author: Siddhesh Poyarekar <siddhesh@sourceware.org>
Date:   Mon Feb 21 08:26:06 2022 +0530

    realpath: Do not copy result on failure (BZ #28815)

    On failure, the contents of the resolved buffer passed in by the caller
    to realpath are undefined.  Do not copy any partial resolution to the
    buffer and also do not test resolved contents in test-canon.c.

    Resolves: BZ #28815

    Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
    Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/28815] realpath should not copy to resolved buffer on error

[siddhesh at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28815

Siddhesh Poyarekar <siddhesh at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |2.36
         Resolution|---                         |FIXED

--- Comment #2 from Siddhesh Poyarekar <siddhesh at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/28815] realpath should not copy to resolved buffer on error

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28815

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=28996

-- 
You are receiving this mail because:
You are on the CC list for the bug.