[Bug libc/28838] New: FAIL: elf/tst-p_align3

[Bug libc/28838] New: FAIL: elf/tst-p_align3

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28838

            Bug ID: 28838
           Summary: FAIL: elf/tst-p_align3
           Product: glibc
           Version: 2.35
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

tst-p_alignmod3.so has invalid p_align on LOAD segments which can't work
with GNU_RELRO.  We need to pass -z norelro to linker to disable GNU_RELRO
segment to always trigger

.../elf/tst-p_alignmod3.so: ELF load command address/offset not page-aligned

instead of

.../elf/tst-p_alignmod3.so: cannot change memory protections

A patch is posted at

https://sourceware.org/pipermail/libc-alpha/2022-January/135733.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/28838] FAIL: elf/tst-p_align3

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28838

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
A new patch is posted at

https://sourceware.org/pipermail/libc-alpha/2022-January/135905.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/28838] FAIL: elf/tst-p_align3

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28838

Michael Hudson-Doyle <michael.hudson at canonical dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hudson at canonical dot co
                   |                            |m

--- Comment #2 from Michael Hudson-Doyle <michael.hudson at canonical dot com> ---
See https://sourceware.org/bugzilla/show_bug.cgi?id=28838 and
https://sourceware.org/pipermail/libc-alpha/2022-January/135905.html I think

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/28838] FAIL: elf/tst-p_align3

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28838

--- Comment #3 from Michael Hudson-Doyle <michael.hudson at canonical dot com> ---
oops, wrong bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/28838] FAIL: elf/tst-p_align3

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28838

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu.org

--- Comment #4 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
*** Bug 28854 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/28838] FAIL: elf/tst-p_align3

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28838

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2c0915cbf570cb9c8a65f1d20a55c5a7238e5b63

commit 2c0915cbf570cb9c8a65f1d20a55c5a7238e5b63
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Feb 15 06:57:11 2022 -0800

    elf: Check invalid hole in PT_LOAD segments [BZ #28838]

    Changes in v2:

    1. Update commit log.

    commit 163f625cf9becbb82dfec63a29e566324129c0cd
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Tue Dec 21 12:35:47 2021 -0800

        elf: Remove excessive p_align check on PT_LOAD segments [BZ #28688]

    removed the p_align check against the page size.  It caused the loader
    error or crash on elf/tst-p_align3 when loading elf/tst-p_alignmod3.so,
    which has the invalid p_align in PT_LOAD segments, added by

    commit d8d94863ef125a392b929732b37e07dc927fbcd1
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Tue Dec 21 13:42:28 2021 -0800

    The loader failure caused by a negative length passed to __mprotect is
    random, depending on architecture and toolchain.  Update _dl_map_segments
    to detect invalid holes.  This fixes BZ #28838.

    Reviewed-by: Florian Weimer <fweimer@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/28838] FAIL: elf/tst-p_align3

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28838

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The release/2.35/master branch has been updated by H.J. Lu
<hjl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1dd783fafdbc30bd82e078ccab42b9539d3274a5

commit 1dd783fafdbc30bd82e078ccab42b9539d3274a5
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Feb 15 06:57:11 2022 -0800

    elf: Check invalid hole in PT_LOAD segments [BZ #28838]

    Changes in v2:

    1. Update commit log.

    commit 163f625cf9becbb82dfec63a29e566324129c0cd
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Tue Dec 21 12:35:47 2021 -0800

        elf: Remove excessive p_align check on PT_LOAD segments [BZ #28688]

    removed the p_align check against the page size.  It caused the loader
    error or crash on elf/tst-p_align3 when loading elf/tst-p_alignmod3.so,
    which has the invalid p_align in PT_LOAD segments, added by

    commit d8d94863ef125a392b929732b37e07dc927fbcd1
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Tue Dec 21 13:42:28 2021 -0800

    The loader failure caused by a negative length passed to __mprotect is
    random, depending on architecture and toolchain.  Update _dl_map_segments
    to detect invalid holes.  This fixes BZ #28838.

    Reviewed-by: Florian Weimer <fweimer@redhat.com>
    (cherry picked from commit 2c0915cbf570cb9c8a65f1d20a55c5a7238e5b63)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/28838] FAIL: elf/tst-p_align3

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28838

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.36

--- Comment #7 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for 2.36 and on 2.35 branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.