public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug locale/28845] New: ld-monetary.c should be updated to match ISO C and other standards.
@ 2022-02-01 14:18 carlos at redhat dot com
  2022-02-03 20:19 ` [Bug locale/28845] " schwab@linux-m68k.org
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: carlos at redhat dot com @ 2022-02-01 14:18 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28845

            Bug ID: 28845
           Summary: ld-monetary.c should be updated to match ISO C and
                    other standards.
           Product: glibc
           Version: 2.35
            Status: NEW
          Severity: normal
          Priority: P2
         Component: locale
          Assignee: unassigned at sourceware dot org
          Reporter: carlos at redhat dot com
  Target Milestone: ---

In ./locale/programs/ld-monetary.c we have copied some text that appears in
monetary_finish() which is taken from other categories, but which does not
apply from a standards perspective.

ISO C's localeconf function requires that various members that can be returned
are allowed to be empty strings "", and so we should not issue warnings for
those cases (7.11.2.3).

This was discovered while harmonizing the C.UTF-8 locale:
https://sourceware.org/pipermail/libc-alpha/2022-February/135955.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug locale/28845] ld-monetary.c should be updated to match ISO C and other standards.
  2022-02-01 14:18 [Bug locale/28845] New: ld-monetary.c should be updated to match ISO C and other standards carlos at redhat dot com
@ 2022-02-03 20:19 ` schwab@linux-m68k.org
  2022-02-03 20:30 ` fweimer at redhat dot com
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: schwab@linux-m68k.org @ 2022-02-03 20:19 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28845

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre.labastie at neuf dot fr

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> ---
*** Bug 28861 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug locale/28845] ld-monetary.c should be updated to match ISO C and other standards.
  2022-02-01 14:18 [Bug locale/28845] New: ld-monetary.c should be updated to match ISO C and other standards carlos at redhat dot com
  2022-02-03 20:19 ` [Bug locale/28845] " schwab@linux-m68k.org
@ 2022-02-03 20:30 ` fweimer at redhat dot com
  2022-02-03 22:18 ` carlos at redhat dot com
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: fweimer at redhat dot com @ 2022-02-03 20:30 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28845

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
localedef -i C -f UTF-8 C.UTF-8

now fails with:

[error] LC_MONETARY: value for field `mon_decimal_point' must not be an empty
string
[error] no output file produced because errors were issued

It turns out we ignore errors during the glibc build (--quiet -c).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug locale/28845] ld-monetary.c should be updated to match ISO C and other standards.
  2022-02-01 14:18 [Bug locale/28845] New: ld-monetary.c should be updated to match ISO C and other standards carlos at redhat dot com
  2022-02-03 20:19 ` [Bug locale/28845] " schwab@linux-m68k.org
  2022-02-03 20:30 ` fweimer at redhat dot com
@ 2022-02-03 22:18 ` carlos at redhat dot com
  2022-02-05  2:57 ` carlos at redhat dot com
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: carlos at redhat dot com @ 2022-02-03 22:18 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28845

--- Comment #3 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Florian Weimer from comment #2)
> localedef -i C -f UTF-8 C.UTF-8
> 
> now fails with:
> 
> [error] LC_MONETARY: value for field `mon_decimal_point' must not be an
> empty string
> [error] no output file produced because errors were issued
> 
> It turns out we ignore errors during the glibc build (--quiet -c).

I have a patch in hand for this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug locale/28845] ld-monetary.c should be updated to match ISO C and other standards.
  2022-02-01 14:18 [Bug locale/28845] New: ld-monetary.c should be updated to match ISO C and other standards carlos at redhat dot com
                   ` (2 preceding siblings ...)
  2022-02-03 22:18 ` carlos at redhat dot com
@ 2022-02-05  2:57 ` carlos at redhat dot com
  2022-02-22 10:18 ` coelacanthus at outlook dot com
  2022-02-25 12:38 ` carlos at redhat dot com
  5 siblings, 0 replies; 7+ messages in thread
From: carlos at redhat dot com @ 2022-02-05  2:57 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28845

--- Comment #4 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Carlos O'Donell from comment #3)
> (In reply to Florian Weimer from comment #2)
> > localedef -i C -f UTF-8 C.UTF-8
> > 
> > now fails with:
> > 
> > [error] LC_MONETARY: value for field `mon_decimal_point' must not be an
> > empty string
> > [error] no output file produced because errors were issued
> > 
> > It turns out we ignore errors during the glibc build (--quiet -c).
> 
> I have a patch in hand for this.

Posted:
https://sourceware.org/pipermail/libc-alpha/2022-February/136161.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug locale/28845] ld-monetary.c should be updated to match ISO C and other standards.
  2022-02-01 14:18 [Bug locale/28845] New: ld-monetary.c should be updated to match ISO C and other standards carlos at redhat dot com
                   ` (3 preceding siblings ...)
  2022-02-05  2:57 ` carlos at redhat dot com
@ 2022-02-22 10:18 ` coelacanthus at outlook dot com
  2022-02-25 12:38 ` carlos at redhat dot com
  5 siblings, 0 replies; 7+ messages in thread
From: coelacanthus at outlook dot com @ 2022-02-22 10:18 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28845

Celeste <coelacanthus at outlook dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |coelacanthus at outlook dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug locale/28845] ld-monetary.c should be updated to match ISO C and other standards.
  2022-02-01 14:18 [Bug locale/28845] New: ld-monetary.c should be updated to match ISO C and other standards carlos at redhat dot com
                   ` (4 preceding siblings ...)
  2022-02-22 10:18 ` coelacanthus at outlook dot com
@ 2022-02-25 12:38 ` carlos at redhat dot com
  5 siblings, 0 replies; 7+ messages in thread
From: carlos at redhat dot com @ 2022-02-25 12:38 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=28845

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.36
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Carlos O'Donell <carlos at redhat dot com> ---
This is now fixed for glibc 2.36.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-02-25 12:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-01 14:18 [Bug locale/28845] New: ld-monetary.c should be updated to match ISO C and other standards carlos at redhat dot com
2022-02-03 20:19 ` [Bug locale/28845] " schwab@linux-m68k.org
2022-02-03 20:30 ` fweimer at redhat dot com
2022-02-03 22:18 ` carlos at redhat dot com
2022-02-05  2:57 ` carlos at redhat dot com
2022-02-22 10:18 ` coelacanthus at outlook dot com
2022-02-25 12:38 ` carlos at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).