[Bug libc/28857] FAIL: elf/tst-audit24a

["adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=28857

--- Comment #6 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
(In reply to dave.anglin from comment #5)
> Created attachment 13960 [details]
> libc_28857-v2.d
> 
> On 2022-02-04 1:53 p.m., adhemerval.zanella at linaro dot org wrote:
> > The _dl_lookup_address seems to be indeed required and I also think we should
> > only updated the binding if la_symbind actually acts uppon it.  The following
> > patch fixes the tests on hppa:
> Attached is an updated patch.  The change to DL_FIXUP_BINDNOW_RELOC was not
> correct.
> As far as I can tell, it is not necessary to call _dl_lookup_address.  But
> we do need to clear the
> plabel bit from new_value or st_value.  I think the same issue could also
> potentially occur with
> DL_FIXUP_ADDR_VALUE.
> 
> I also hacked things a bit to fix warning from dl-fptr.c.
> 
> I'm still not sure where the nameless R_PARISC_IPLT relocation comes from.

I will update the patch by just masking off the plabel bit as you suggested. I
am not sure about DL_FIXUP_ADDR_VALUE change since it is unrelated to this
issue, but it does seem reasonable.

The dl-fptr.c warning fixes I would prefer to send in a different path.

-- 
You are receiving this mail because:
You are on the CC list for the bug.