public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "siddhesh at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug string/29265] mbstowcs with NULL dst throws an incorrect warning (glibc == 2.35, gcc=12.0.1)
Date: Tue, 21 Jun 2022 04:45:10 +0000	[thread overview]
Message-ID: <bug-29265-131-HuxAlcDA7o@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29265-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29265

--- Comment #6 from Siddhesh Poyarekar <siddhesh at sourceware dot org> ---
(In reply to Noah Goldstein from comment #5)
> (In reply to Siddhesh Poyarekar from comment #4)
> > I'm not very picky about having a test for this FWIW, this seems very
> > sensitive to optimizations and may not survive gcc updates.
> > 
> > As for the fix, just remove the  __attr_access ((__write_only__, 1, 3)),
> > it's incorrect in the context of mbstowcs definition.
> 
> You don't think its worth preserving if dst is non-null? In that case it is
> meaningful no?

It is meaningful, just that the check may trigger if the dest pointer has not
yet been simplified to a const.  Although, maybe I'm overthinking it.  Lets go
with what you have.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-06-21  4:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20 14:01 [Bug string/29265] New: " goldstein.w.n at gmail dot com
2022-06-21  2:37 ` [Bug string/29265] " siddhesh at sourceware dot org
2022-06-21  2:44 ` goldstein.w.n at gmail dot com
2022-06-21  3:30 ` goldstein.w.n at gmail dot com
2022-06-21  3:46 ` siddhesh at sourceware dot org
2022-06-21  4:26 ` goldstein.w.n at gmail dot com
2022-06-21  4:45 ` siddhesh at sourceware dot org [this message]
2022-08-06  9:16 ` vincent.vsmeets at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29265-131-HuxAlcDA7o@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).