[Bug math/29326] New: Usage of double in sqrtf

[Bug math/29326] New: Usage of double in sqrtf

[stefan.arnold@aim-messtechnik.de]

https://sourceware.org/bugzilla/show_bug.cgi?id=29326

            Bug ID: 29326
           Summary: Usage of double in sqrtf
           Product: glibc
           Version: unspecified
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: math
          Assignee: unassigned at sourceware dot org
          Reporter: stefan.arnold@aim-messtechnik.de
  Target Milestone: ---

The function "__ieee754_sqrtf" in sysdeps/ieee754/flt-32/e_sqrtf.c has an
imlicit double conversion in lines 76 and 78. As this is quite useless and
costly especially on microcontrollers i suggest adding an "f" suffix to the
numbers.

--- a/sysdeps/ieee754/flt-32/e_sqrtf.c
+++ b/sysdeps/ieee754/flt-32/e_sqrtf.c
@@ -73,9 +73,9 @@ __ieee754_sqrtf(float x)
     /* use floating add to find out rounding direction */
        if(ix!=0) {
            z = 0x1p0 - 0x1.4484cp-100; /* trigger inexact flag.  */
-           if (z >= 0x1p0) {
+           if (z >= 0x1p0f) {
                z = 0x1p0 + 0x1.4484cp-100;
-               if (z > 0x1p0)
+               if (z > 0x1p0f)
                    q += 2;
                else
                    q += (q&1);
--

-- 
You are receiving this mail because:
You are on the CC list for the bug.