[Bug build/29485] New: Make hangs when the test misc/tst-pidfile returns FAIL_UNSUPPORTED

[Bug build/29485] New: Make hangs when the test misc/tst-pidfile returns FAIL_UNSUPPORTED

[freswa at archlinux dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29485

            Bug ID: 29485
           Summary: Make hangs when the test misc/tst-pidfile returns
                    FAIL_UNSUPPORTED
           Product: glibc
           Version: 2.36
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: freswa at archlinux dot org
                CC: carlos at redhat dot com
  Target Milestone: ---

Created attachment 14275
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14275&action=edit
Patch fixing the bug

Arch Linux builds glibc in a systemd-nspawn. To avoid issues with the
testsuite, we disable some tests that require syscalls not allowed by nspawn.
Commit (bisected) 325ba824b0611e14e96b38dbc486acf255f9e568 introduced a hang of
make after printing the test summary at the end.

The root cause in sysdeps/unix/sysv/linux/tst-pidfd.c is the early return in
line 150 which is causing the process, spawned in line 46, to hang on line 84
waiting for the signal in line 170.

Patch attached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29485] Make hangs when the test misc/tst-pidfile returns FAIL_UNSUPPORTED

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29485

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29485] Make hangs when the test misc/tst-pidfile returns FAIL_UNSUPPORTED

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29485

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #1 from Sam James <sam at gentoo dot org> ---
CCing mjw.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29485] Make hangs when the test misc/tst-pidfile returns FAIL_UNSUPPORTED

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29485

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-
                 CC|                            |fweimer at redhat dot com

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
Patch posted:

[PATCH] Linux: Terminate subprocess on late failure in tst-pidfd (bug 29485)
<https://sourceware.org/pipermail/libc-alpha/2022-August/141414.html>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29485] Make hangs when the test misc/tst-pidfile returns FAIL_UNSUPPORTED

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29485

--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
Thanks for noticing this. I missed this in the buildbot testing since the whole
make check is wrapped in a timeout. The test itself succeeds (gets marked
UNSUPPORTED). But the subprocess still runs causing make check to hang. In the
buildbot runs this then gets cleaned up after make check stops producing output
for a couple of minutes. The proposed fix looks OK (but I haven't tested it
yet).

-- 
You are receiving this mail because:
You are on the CC list for the bug.