public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/29771] New: Restore IPC_64 support in sysvipc *ctl functions
@ 2022-11-10 10:36 fweimer at redhat dot com
2022-11-10 10:36 ` [Bug libc/29771] " fweimer at redhat dot com
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: fweimer at redhat dot com @ 2022-11-10 10:36 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29771
Bug ID: 29771
Summary: Restore IPC_64 support in sysvipc *ctl functions
Product: glibc
Version: 2.37
Status: NEW
Severity: normal
Priority: P2
Component: libc
Assignee: unassigned at sourceware dot org
Reporter: fweimer at redhat dot com
CC: drepper.fsp at gmail dot com
Target Milestone: ---
Flags: security-
In order to call SHM_STAT_ANY kernel operations through shmctl on older glibc,
it was necessary to pass SHM_STAT_ANY | IPC_64 in the command argument,
otherwise the ipc system call would be invoked without the IPC_64 flag, giving
unexpected results on powerpc64le-linux-gnu at least.
Current glibc no longer supports that because it checks the command argument
for validity without masking the IPC_64 bit.
Patch posted:
[PATCH] Linux: Support __IPC_64 in sysvctl *ctl command arguments
<https://sourceware.org/pipermail/libc-alpha/2022-November/143343.html>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libc/29771] Restore IPC_64 support in sysvipc *ctl functions
2022-11-10 10:36 [Bug libc/29771] New: Restore IPC_64 support in sysvipc *ctl functions fweimer at redhat dot com
@ 2022-11-10 10:36 ` fweimer at redhat dot com
2022-11-10 10:37 ` fweimer at redhat dot com
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: fweimer at redhat dot com @ 2022-11-10 10:36 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29771
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |fweimer at redhat dot com
Status|NEW |ASSIGNED
CC| |fweimer at redhat dot com
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libc/29771] Restore IPC_64 support in sysvipc *ctl functions
2022-11-10 10:36 [Bug libc/29771] New: Restore IPC_64 support in sysvipc *ctl functions fweimer at redhat dot com
2022-11-10 10:36 ` [Bug libc/29771] " fweimer at redhat dot com
@ 2022-11-10 10:37 ` fweimer at redhat dot com
2022-11-10 10:54 ` fweimer at redhat dot com
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: fweimer at redhat dot com @ 2022-11-10 10:37 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29771
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://sourceware.org/bugz
| |illa/show_bug.cgi?id=26637
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libc/29771] Restore IPC_64 support in sysvipc *ctl functions
2022-11-10 10:36 [Bug libc/29771] New: Restore IPC_64 support in sysvipc *ctl functions fweimer at redhat dot com
2022-11-10 10:36 ` [Bug libc/29771] " fweimer at redhat dot com
2022-11-10 10:37 ` fweimer at redhat dot com
@ 2022-11-10 10:54 ` fweimer at redhat dot com
2022-11-10 13:23 ` fweimer at redhat dot com
2022-11-11 18:16 ` fweimer at redhat dot com
4 siblings, 0 replies; 6+ messages in thread
From: fweimer at redhat dot com @ 2022-11-10 10:54 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29771
--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
Applications cannot simply call the underlying system call directly because
shmctl is not universally supported, and the ipc dispatcher has to be used
instead on certain kernels. I think this is an unnecessary burden on
applications, which is why I think we should keep support for the IPC_64 flag
argument.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libc/29771] Restore IPC_64 support in sysvipc *ctl functions
2022-11-10 10:36 [Bug libc/29771] New: Restore IPC_64 support in sysvipc *ctl functions fweimer at redhat dot com
` (2 preceding siblings ...)
2022-11-10 10:54 ` fweimer at redhat dot com
@ 2022-11-10 13:23 ` fweimer at redhat dot com
2022-11-11 18:16 ` fweimer at redhat dot com
4 siblings, 0 replies; 6+ messages in thread
From: fweimer at redhat dot com @ 2022-11-10 13:23 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29771
--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
Fixed in glibc 2.37 via:
commit 22a46dee24351fd5f4f188ad80554cad79c82524
Author: Florian Weimer <fweimer@redhat.com>
Date: Tue Nov 8 14:15:02 2022 +0100
Linux: Support __IPC_64 in sysvctl *ctl command arguments (bug 29771)
Old applications pass __IPC_64 as part of the command argument because
old glibc did not check for unknown commands, and passed through the
arguments directly to the kernel, without adding __IPC_64.
Applications need to continue doing that for old glibc compatibility,
so this commit enables this approach in current glibc.
For msgctl and shmctl, if no translation is required, make
direct system calls, as we did before the time64 changes. If
translation is required, mask __IPC_64 from the command argument.
For semctl, the union-in-vararg argument handling means that
translation is needed on all architectures.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libc/29771] Restore IPC_64 support in sysvipc *ctl functions
2022-11-10 10:36 [Bug libc/29771] New: Restore IPC_64 support in sysvipc *ctl functions fweimer at redhat dot com
` (3 preceding siblings ...)
2022-11-10 13:23 ` fweimer at redhat dot com
@ 2022-11-11 18:16 ` fweimer at redhat dot com
4 siblings, 0 replies; 6+ messages in thread
From: fweimer at redhat dot com @ 2022-11-11 18:16 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29771
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Target Milestone|--- |2.37
Status|ASSIGNED |RESOLVED
--- Comment #3 from Florian Weimer <fweimer at redhat dot com> ---
Backports complete.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-11 18:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 10:36 [Bug libc/29771] New: Restore IPC_64 support in sysvipc *ctl functions fweimer at redhat dot com
2022-11-10 10:36 ` [Bug libc/29771] " fweimer at redhat dot com
2022-11-10 10:37 ` fweimer at redhat dot com
2022-11-10 10:54 ` fweimer at redhat dot com
2022-11-10 13:23 ` fweimer at redhat dot com
2022-11-11 18:16 ` fweimer at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).