public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug dynamic-link/29776] New: elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 @ 2022-11-11 15:47 fweimer at redhat dot com 2022-11-12 1:13 ` [Bug dynamic-link/29776] " amodra at gmail dot com ` (3 more replies) 0 siblings, 4 replies; 5+ messages in thread From: fweimer at redhat dot com @ 2022-11-11 15:47 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=29776 Bug ID: 29776 Summary: elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 Product: glibc Version: unspecified Status: NEW Severity: normal Priority: P2 Component: dynamic-link Assignee: unassigned at sourceware dot org Reporter: fweimer at redhat dot com CC: amodra at gmail dot com, rajis at linux dot ibm.com Target Milestone: --- Target: powerpc64le-linux-gnu tls_get_addr_opt_test in sysdeps/powerpc/mod-tlsopt-powerpc.c contains: #ifdef __powerpc64__ register unsigned long thread_pointer __asm__ ("r13"); asm ("addi %0,2,foo@got@tlsgd" : "=r" (tls_arg)); #else If I'm not mistaken, this assumes that r2 is the TOC register. However, when building in PCREL mode (e.g., with CC="gcc -mcpu=power10"), there is no TOC register for this function. In fact, r2 is zero, and we get a crash for the tls_arg->ti_module != 0 check. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug dynamic-link/29776] elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 2022-11-11 15:47 [Bug dynamic-link/29776] New: elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 fweimer at redhat dot com @ 2022-11-12 1:13 ` amodra at gmail dot com 2022-11-13 19:33 ` rajis at linux dot ibm.com ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: amodra at gmail dot com @ 2022-11-12 1:13 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=29776 --- Comment #1 from Alan Modra <amodra at gmail dot com> --- Created attachment 14451 --> https://sourceware.org/bugzilla/attachment.cgi?id=14451&action=edit untested patch This should fix it. Note that I haven't actually run a glibc regression test on a power10 box, just looked at generated code. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug dynamic-link/29776] elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 2022-11-11 15:47 [Bug dynamic-link/29776] New: elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 fweimer at redhat dot com 2022-11-12 1:13 ` [Bug dynamic-link/29776] " amodra at gmail dot com @ 2022-11-13 19:33 ` rajis at linux dot ibm.com 2022-11-14 11:15 ` fweimer at redhat dot com 2022-11-14 11:37 ` amodra at gmail dot com 3 siblings, 0 replies; 5+ messages in thread From: rajis at linux dot ibm.com @ 2022-11-13 19:33 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=29776 --- Comment #2 from Rajalakshmi <rajis at linux dot ibm.com> --- Tested the patch on power10 with flag -mcpu=power10 and it fixed elf/tst-tlsopt-powerpc failure. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug dynamic-link/29776] elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 2022-11-11 15:47 [Bug dynamic-link/29776] New: elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 fweimer at redhat dot com 2022-11-12 1:13 ` [Bug dynamic-link/29776] " amodra at gmail dot com 2022-11-13 19:33 ` rajis at linux dot ibm.com @ 2022-11-14 11:15 ` fweimer at redhat dot com 2022-11-14 11:37 ` amodra at gmail dot com 3 siblings, 0 replies; 5+ messages in thread From: fweimer at redhat dot com @ 2022-11-14 11:15 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=29776 Florian Weimer <fweimer at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fweimer at redhat dot com --- Comment #3 from Florian Weimer <fweimer at redhat dot com> --- (In reply to Alan Modra from comment #1) > Created attachment 14451 [details] > untested patch > > This should fix it. Note that I haven't actually run a glibc regression > test on a power10 box, just looked at generated code. (In reply to Rajalakshmi from comment #2) > Tested the patch on power10 with flag -mcpu=power10 and it fixed > elf/tst-tlsopt-powerpc failure. Thanks! Could we please merge this into the master branch? -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug dynamic-link/29776] elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 2022-11-11 15:47 [Bug dynamic-link/29776] New: elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 fweimer at redhat dot com ` (2 preceding siblings ...) 2022-11-14 11:15 ` fweimer at redhat dot com @ 2022-11-14 11:37 ` amodra at gmail dot com 3 siblings, 0 replies; 5+ messages in thread From: amodra at gmail dot com @ 2022-11-14 11:37 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=29776 Alan Modra <amodra at gmail dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|amodra at gmail dot com | Assignee|unassigned at sourceware dot org |amodra at gmail dot com Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Alan Modra <amodra at gmail dot com> --- pushed commit 94628de77888 -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-14 11:37 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-11-11 15:47 [Bug dynamic-link/29776] New: elf/tst-tlsopt-powerpc fails when compiled with -mcpu=power10 fweimer at redhat dot com 2022-11-12 1:13 ` [Bug dynamic-link/29776] " amodra at gmail dot com 2022-11-13 19:33 ` rajis at linux dot ibm.com 2022-11-14 11:15 ` fweimer at redhat dot com 2022-11-14 11:37 ` amodra at gmail dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).