[Bug time/30156] New: Potential ntp_gettime abi break

[Bug time/30156] New: Potential ntp_gettime abi break

[vfjpl1 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30156

            Bug ID: 30156
           Summary: Potential ntp_gettime abi break
           Product: glibc
           Version: 2.32
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: time
          Assignee: unassigned at sourceware dot org
          Reporter: vfjpl1 at gmail dot com
  Target Milestone: ---

Between versions v2.11 and v2.12 struct ntptimeval got new fields.
That wasn't a problem because new function ntp_gettimex was created
(and made default) to support new struct. Old ntp_gettime was not
using new fields so it was safe to call with old struct
definition. Then between versions v2.31 and v2.32 when working on
y2038 support, ntp_gettime start setting new fields. Is my reasoning correct
that this constitutes abi break for old binaries using ntp_gettime function?


And second question.
what about ntptimeval struct getting new members. Wasn't that abi break if for
example some library used that struct in their public interface?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug time/30156] Potential ntp_gettime abi break

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30156

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug time/30156] Potential ntp_gettime abi break

[vfjpl1 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30156

--- Comment #1 from Kacper Piwiński <vfjpl1 at gmail dot com> ---
Created attachment 14706
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14706&action=edit
patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug time/30156] Potential ntp_gettime abi break

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30156

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg
   Target Milestone|---                         |2.38
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
Fixed on 2.38.

-- 
You are receiving this mail because:
You are on the CC list for the bug.