[Bug libc/30263] New: Add test coverage for abs(), labs(), and llabs().

[Bug libc/30263] New: Add test coverage for abs(), labs(), and llabs().

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30263

            Bug ID: 30263
           Summary: Add test coverage for abs(), labs(), and llabs().
           Product: glibc
           Version: 2.38
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: carlos at redhat dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

We should have test coverage for abs(), labs(), and llabs(), particularly
around all the transition points for each of the types e.g. int, long, long
long.

We currently don't have any tests for these functions, presumably because they
are simple, but we should still test them.

Tests should go into stdlib/ because that's where the implementation for the
functions exists. Tests should use the modern support/ test framework e.g.
#include <test-driver.c>.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/30263] Add test coverage for abs(), labs(), and llabs().

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30263

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |good-first-bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/30263] Add test coverage for abs(), labs(), and llabs().

[joseph at codesourcery dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30263

--- Comment #1 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
Make sure to use -fno-builtin on such tests, otherwise they won't be 
testing the library functions at all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/30263] Add test coverage for abs(), labs(), and llabs().

[siddhesh at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30263

Siddhesh Poyarekar <siddhesh at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.38
                 CC|                            |siddhesh at sourceware dot org

--- Comment #2 from Siddhesh Poyarekar <siddhesh at sourceware dot org> ---
Fixed.

commit d877b52d58b1c73810751bdb48987b84bda87d5e (HEAD -> master, origin/master,
origin/HEAD)
Author: Joe Simmons-Talbott <josimmon@redhat.com>
Date:   Tue Apr 4 09:57:47 2023 -0400

    stdlib: Add testcases for llabs(). (BZ #30263)

    Test minimum and maximum long long values, zero, 32bit crossover points,
and
    part of the range of long long values.  Use '-fno-builtin' to ensure we are
    testing the implementation.

    Reviewed-by: Wilco Dijkstra  <Wilco.Dijkstra@arm.com>

commit b11db301e162480d1812937ab0410dc7585f423c
Author: Joe Simmons-Talbott <josimmon@redhat.com>
Date:   Tue Apr 4 09:57:46 2023 -0400

    stdlib: Add testcases for labs(). (BZ #30263)

    Test minimum and maximum long values, zero, and part of the range
    of long values.  Use '-fno-builtin' to ensure we are testing the
    implementation.

    Reviewed-by: Wilco Dijkstra  <Wilco.Dijkstra@arm.com>

commit 0d21b3783f49ae94207a1bb9acd5dc8b071f0b13
Author: Joe Simmons-Talbott <josimmon@redhat.com>
Date:   Tue Apr 4 09:57:45 2023 -0400

    stdlib: Add testcases for abs(). (BZ #30263)

    Test minimum and maximum int values, zero, and part of the range
    of int values.  Use '-fno-builtin' to ensure we are testing the
    implementation.

    Reviewed-by: Wilco Dijkstra  <Wilco.Dijkstra@arm.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.