public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/30266] New: Add test coverage for strdup() and strndup()
@ 2023-03-23 13:58 carlos at redhat dot com
  2023-03-23 13:59 ` [Bug libc/30266] " carlos at redhat dot com
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: carlos at redhat dot com @ 2023-03-23 13:58 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=30266

            Bug ID: 30266
           Summary: Add test coverage for strdup() and strndup()
           Product: glibc
           Version: 2.38
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: carlos at redhat dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

The strdup() and strndup() function is largely implemented on top of malloc(),
but have close to no coverage testing for the individual functions and their
semantics (except for 1-3 small tests of simple behaviour).

We need to test these functions with various inputs, aligned, unaligned, and
under various conditions of null pointers etc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libc/30266] Add test coverage for strdup() and strndup()
  2023-03-23 13:58 [Bug libc/30266] New: Add test coverage for strdup() and strndup() carlos at redhat dot com
@ 2023-03-23 13:59 ` carlos at redhat dot com
  2023-03-23 15:41 ` carlos at redhat dot com
  2023-10-30 15:31 ` carlos at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: carlos at redhat dot com @ 2023-03-23 13:59 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=30266

--- Comment #1 from Carlos O'Donell <carlos at redhat dot com> ---
Should verify that they return malloc-aligned strings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libc/30266] Add test coverage for strdup() and strndup()
  2023-03-23 13:58 [Bug libc/30266] New: Add test coverage for strdup() and strndup() carlos at redhat dot com
  2023-03-23 13:59 ` [Bug libc/30266] " carlos at redhat dot com
@ 2023-03-23 15:41 ` carlos at redhat dot com
  2023-10-30 15:31 ` carlos at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: carlos at redhat dot com @ 2023-03-23 15:41 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=30266

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |good-first-bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libc/30266] Add test coverage for strdup() and strndup()
  2023-03-23 13:58 [Bug libc/30266] New: Add test coverage for strdup() and strndup() carlos at redhat dot com
  2023-03-23 13:59 ` [Bug libc/30266] " carlos at redhat dot com
  2023-03-23 15:41 ` carlos at redhat dot com
@ 2023-10-30 15:31 ` carlos at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: carlos at redhat dot com @ 2023-10-30 15:31 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=30266

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.38
             Status|NEW                         |RESOLVED

--- Comment #2 from Carlos O'Donell <carlos at redhat dot com> ---
Coverage was improved by Joe Simmons-Talbott.

commit eaaad78db41724e5a18a42becb238bfc4e683998
Author: Joe Simmons-Talbott <josimmon@redhat.com>
Date:   Fri Apr 21 09:24:23 2023 -0400

    string: Add tests for strdup (BZ #30266)

    Copy strcpy tests for strdup.  Covers some basic testcases with random
    strings.  Add a zero-length string testcase.

    Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-10-30 15:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 13:58 [Bug libc/30266] New: Add test coverage for strdup() and strndup() carlos at redhat dot com
2023-03-23 13:59 ` [Bug libc/30266] " carlos at redhat dot com
2023-03-23 15:41 ` carlos at redhat dot com
2023-10-30 15:31 ` carlos at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).