[Bug malloc/30303] New: FAIL: malloc/tst-memalign-2-mcheck

[Bug malloc/30303] New: FAIL: malloc/tst-memalign-2-mcheck

[danglin at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30303

            Bug ID: 30303
           Summary: FAIL: malloc/tst-memalign-2-mcheck
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: malloc
          Assignee: unassigned at sourceware dot org
          Reporter: danglin at gcc dot gnu.org
  Target Milestone: ---
              Host: hppa*-*-linux*
            Target: hppa*-*-linux*
             Build: hppa*-*-linux*

dave@mx3210:~/gnu/glibc/objdir$ make test t=malloc/tst-memalign-2-mcheck
LD_LIBRARY_PATH=`pwd`; export LD_LIBRARY_PATH; \
make -r PARALLELMFLAGS="" -C ../glibc objdir=`pwd` test
make[1]: Entering directory '/home/dave/gnu/glibc/glibc'
make subdir=malloc -C malloc/ ..=../
/home/dave/gnu/glibc/objdir/malloc/tst-memalign-2-mcheck.out
make[2]: Entering directory '/home/dave/gnu/glibc/glibc/malloc'
env GCONV_PATH=/home/dave/gnu/glibc/objdir/iconvdata
LOCPATH=/home/dave/gnu/glibc/objdir/localedata LC_ALL=C
LD_PRELOAD=/home/dave/gnu/glibc/objdir//malloc/libc_malloc_debug.so 
/home/dave/gnu/glibc/objdir/elf/ld.so.1 --library-path
/home/dave/gnu/glibc/objdir:/home/dave/gnu/glibc/objdir/math:/home/dave/gnu/glibc/objdir/elf:/home/dave/gnu/glibc/objdir/dlfcn:/home/dave/gnu/glibc/objdir/nss:/home/dave/gnu/glibc/objdir/nis:/home/dave/gnu/glibc/objdir/rt:/home/dave/gnu/glibc/objdir/resolv:/home/dave/gnu/glibc/objdir/mathvec:/home/dave/gnu/glibc/objdir/support:/home/dave/gnu/glibc/objdir/crypt:/home/dave/gnu/glibc/objdir/nptl
/home/dave/gnu/glibc/objdir/malloc/tst-memalign-2-mcheck  >
/home/dave/gnu/glibc/objdir/malloc/tst-memalign-2-mcheck.out; \
../scripts/evaluate-test.sh malloc/tst-memalign-2-mcheck $? false false >
/home/dave/gnu/glibc/objdir/malloc/tst-memalign-2-mcheck.test-result
make[2]: Leaving directory '/home/dave/gnu/glibc/glibc/malloc'
FAIL: malloc/tst-memalign-2-mcheck
original exit status 1
error: tst-memalign-2.c:81: not true: tcache_allocs[i].ptr1 ==
tcache_allocs[i].ptr2
error: 1 test failures
make[1]: Leaving directory '/home/dave/gnu/glibc/glibc'

I believe this fails for i == 2:
env GCONV_PATH=/home/dave/gnu/glibc/objdir/iconvdata
LOCPATH=/home/dave/gnu/glibc/objdir/localedata LC_ALL=C
LD_PRELOAD=/home/dave/gnu/glibc/objdir//malloc/libc_malloc_debug.so 
/home/dave/gnu/glibc/objdir/elf/ld.so.1 --library-path
/home/dave/gnu/glibc/objdir:/home/dave/gnu/glibc/objdir/math:/home/dave/gnu/glibc/objdir/elf:/home/dave/gnu/glibc/objdir/dlfcn:/home/dave/gnu/glibc/objdir/nss:/home/dave/gnu/glibc/objdir/nis:/home/dave/gnu/glibc/objdir/rt:/home/dave/gnu/glibc/objdir/resolv:/home/dave/gnu/glibc/objdir/mathvec:/home/dave/gnu/glibc/objdir/support:/home/dave/gnu/glibc/objdir/crypt:/home/dave/gnu/glibc/objdir/nptl
/home/dave/gnu/glibc/objdir/malloc/tst-memalign-2-mcheck  >
/home/dave/gnu/glibc/objdir/malloc/tst-memalign-2-mcheck.out; \
../scripts/evaluate-test.sh malloc/tst-memalign-2-mcheck $? false false >
/home/dave/gnu/glibc/objdir/malloc/tst-memalign-2-mcheck.test-result
make[2]: Leaving directory '/home/dave/gnu/glibc/glibc/malloc'
FAIL: malloc/tst-memalign-2-mcheck
original exit status 1
i=0 ptr1=0x0xf78c91b8 ptr2=0x0xf78c91b8
i=1 ptr1=0x0xf78c9210 ptr2=0x0xf78c9260
error: tst-memalign-2.c:85: not true: ptr1 == ptr2
i=2 ptr1=0x0xf78c92e0 ptr2=0x0xf78c92e0
error: 1 test failures

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug malloc/30303] FAIL: malloc/tst-memalign-2-mcheck

[danglin at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30303

--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> ---
Sorry, the fail occurs at i = 1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug malloc/30303] FAIL: malloc/tst-memalign-2-mcheck

[danglin at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30303

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dj at redhat dot com

--- Comment #2 from John David Anglin <danglin at gcc dot gnu.org> ---
Introduced by following commit:

dave@mx3210:~/gnu/glibc/glibc$ git bisect good
24cdd6c71debfd10a9f7cb217fe2a2c4c486ed6f is the first bad commit
commit 24cdd6c71debfd10a9f7cb217fe2a2c4c486ed6f
Author: DJ Delorie <dj@redhat.com>
Date:   Wed Mar 29 00:18:40 2023 -0400

    memalign: Support scanning for aligned chunks.

    This patch adds a chunk scanning algorithm to the _int_memalign code
    path that reduces heap fragmentation by reusing already aligned chunks
    instead of always looking for chunks of larger sizes and splitting
    them.  The tcache macros are extended to allow removing a chunk from
    the middle of the list.

    The goal is to fix the pathological use cases where heaps grow
    continuously in workloads that are heavy users of memalign.

    Note that tst-memalign-2 checks for tcache operation, which
    malloc-check bypasses.

    Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

 malloc/Makefile         |   3 +-
 malloc/malloc.c         | 260 +++++++++++++++++++++++++++++++++++++++++++-----
 malloc/tst-memalign-2.c | 155 +++++++++++++++++++++++++++++
 3 files changed, 390 insertions(+), 28 deletions(-)
 create mode 100644 malloc/tst-memalign-2.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug malloc/30303] FAIL: malloc/tst-memalign-2-mcheck

[dj at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30303

--- Comment #3 from dj at redhat dot com <dj at redhat dot com> ---
You need e5524ef335dc8e28d64cc376d57c219e566fcf53 which excludes those tests
from the mcheck test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug malloc/30303] FAIL: malloc/tst-memalign-2-mcheck

[danglin at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30303

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from John David Anglin <danglin at gcc dot gnu.org> ---
Fixed by commit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.