[Bug build/30554] New: glibcpp.py doesn't handle "\"

[Bug build/30554] New: glibcpp.py doesn't handle "\"

[maxim.kuvyrkov at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30554

            Bug ID: 30554
           Summary: glibcpp.py doesn't handle "\"
           Product: glibc
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: maxim.kuvyrkov at gmail dot com
                CC: carlos at redhat dot com
  Target Milestone: ---

This patch [1] to update elf/elf.h fails pre-commit testing due to failures in
...
===
Running glibc:elf ...
FAIL: elf/tst-glibcelf 
FAIL: elf/tst-relro-ldso 
FAIL: elf/tst-relro-libc 
===
... tests.

All these tests fail with the following error ...
===
$ cat tst-glibcelf.out 
/home/maxim.kuvyrkov/tcwg_gnu/glibc/scripts/../elf/elf.h:1708: error:
uninterpretable macro token sequence: \
0x02000000
Traceback (most recent call last):
 File "/home/maxim.kuvyrkov/tcwg_gnu/glibc/elf/tst-glibcelf.py", line 23, in
<module>
   import glibcelf
 File "/home/maxim.kuvyrkov/tcwg_gnu/glibc/scripts/glibcelf.py", line 226, in
<module>
   _elf_h = _parse_elf_h()
 File "/home/maxim.kuvyrkov/tcwg_gnu/glibc/scripts/glibcelf.py", line 223, in
_parse_elf_h
   raise IOError('parse error in elf.h')
OSError: parse error in elf.h
===
... while parsing new lines:
#define EF_MIPS_ARCH_ASE_MICROMIPS \
                                0x02000000 /* Use MICROMIPS ISA
                                              extensions.  */

The workaround to unblock this patch is to remove "\" from the macro
definition, but it would be nice to improve glibcpp.py to handle split lines.

[1]
https://patchwork.sourceware.org/project/glibc/patch/20230606061328.245050-1-ying.huang@oss.cipunited.com/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30554] glibcpp.py doesn't handle "\"

[maxim.kuvyrkov at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30554

Maxim Kuvyrkov <maxim.kuvyrkov at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

--- Comment #1 from Maxim Kuvyrkov <maxim.kuvyrkov at gmail dot com> ---
Hi Florian,

Could you take a look at this?  After looking for a few minutes at glibcpp.py
it doesn't seem like I can figure this out quickly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30554] glibcpp.py doesn't handle "\"

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30554

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
I agree it probably falls on me to implement this, but it's going to take some
time until I can look into this, sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.