public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug build/31196] master fails to build on s390 with --disable-multi-arch Date: Mon, 29 Jan 2024 12:54:23 +0000 [thread overview] Message-ID: <bug-31196-131-2LiYrOLW4I@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-31196-131@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=31196 Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adhemerval.zanella at linaro dot o | |rg --- Comment #5 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> --- The recent s390 string refactor assumed multiarch/ifunc support as default and organized the internal code without placing the ifunc selector/variants only on multiarch folder. This is to allow the avoid ifunc and some string variants depending of the default compiler optimization (so if you target glibc to a z13, there is no need to provide old z900 variants and glibc internally can assume the z13 variants as default). I am not very found of this s390-specific organization, it differs from other ports where there is no need to extra internal checks to see if you are building with multiarch support (USE_MULTIARCH). The following patch should fix s390 and s390x, but I think it would be better to make s390 follow current practice of putting ifunc support only at multiarch folders. diff --git a/sysdeps/s390/memrchr-c.c b/sysdeps/s390/memrchr-c.c index bdf3c7bbe0..3cb27b795d 100644 --- a/sysdeps/s390/memrchr-c.c +++ b/sysdeps/s390/memrchr-c.c @@ -25,7 +25,7 @@ # include <string/memrchr.c> -# if defined SHARED && IS_IN (libc) +# if defined SHARED && IS_IN (libc) && defined USE_MULTIARCH __hidden_ver1 (__memrchr_c, __GI___memrchr, __memrchr_c); # endif #endif diff --git a/sysdeps/s390/strchrnul-c.c b/sysdeps/s390/strchrnul-c.c index f6f5bae311..cee0e1a89e 100644 --- a/sysdeps/s390/strchrnul-c.c +++ b/sysdeps/s390/strchrnul-c.c @@ -24,7 +24,7 @@ # endif # include <string/strchrnul.c> -# if defined SHARED && IS_IN (libc) +# if defined SHARED && IS_IN (libc) && defined USE_MULTIARCH __hidden_ver1 (__strchrnul_c, __GI___strchrnul, __strchrnul_c); # endif #endif -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2024-01-29 12:54 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-28 18:34 [Bug build/31196] New: glibc-2.38 (tip of release branch) fails to build on s390 (gcc-13 to blame?) dilfridge at gentoo dot org 2023-12-28 18:34 ` [Bug build/31196] " dilfridge at gentoo dot org 2023-12-28 18:35 ` dilfridge at gentoo dot org 2023-12-29 13:11 ` adhemerval.zanella at linaro dot org 2024-01-08 14:28 ` stli at linux dot ibm.com 2024-01-14 23:13 ` dilfridge at gentoo dot org 2024-01-27 21:41 ` sam at gentoo dot org 2024-01-29 1:36 ` dilfridge at gentoo dot org 2024-01-29 1:37 ` [Bug build/31196] master fails to build on s390 with --disable-multi-arch dilfridge at gentoo dot org 2024-01-29 12:54 ` adhemerval.zanella at linaro dot org [this message] 2024-01-29 13:31 ` stli at linux dot ibm.com 2024-01-29 21:16 ` jsm28 at gcc dot gnu.org 2024-01-30 8:46 ` sam at gentoo dot org 2024-01-31 12:12 ` stli at linux dot ibm.com 2024-01-31 12:33 ` dilfridge at gentoo dot org 2024-02-01 9:14 ` stli at linux dot ibm.com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-31196-131-2LiYrOLW4I@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).