public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "xry111 at xry111 dot site" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug libc/31276] New: Wrong condition for heap allocation in qsort_r Date: Mon, 22 Jan 2024 19:54:25 +0000 [thread overview] Message-ID: <bug-31276-131@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=31276 Bug ID: 31276 Summary: Wrong condition for heap allocation in qsort_r Product: glibc Version: 2.39 Status: UNCONFIRMED Severity: normal Priority: P2 Component: libc Assignee: unassigned at sourceware dot org Reporter: xry111 at xry111 dot site CC: drepper.fsp at gmail dot com Target Milestone: --- /* Align to the maximum size used by the swap optimization. */ _Alignas (uint64_t) char tmp[QSORT_STACK_SIZE]; size_t total_size = total_elems * size; char *buf; if (size > INDIRECT_SORT_SIZE_THRES) total_size = 2 * total_elems * sizeof (void *) + size; if (total_size < sizeof buf) buf = tmp; else { /* allocate buf on heap ... */ } Here "sizeof buf" is the size of a pointer, but (obviously?) we want QSORT_STACK_SIZE here, i.e. "sizeof tmp". -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2024-01-22 19:54 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-22 19:54 xry111 at xry111 dot site [this message] 2024-01-23 13:21 ` [Bug libc/31276] " hjl.tools at gmail dot com 2024-01-26 19:30 ` gabravier at gmail dot com 2024-01-27 11:09 ` sam at gentoo dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-31276-131@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).