public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug libc/31276] New: Wrong condition for heap allocation in qsort_r
@ 2024-01-22 19:54 xry111 at xry111 dot site
2024-01-23 13:21 ` [Bug libc/31276] " hjl.tools at gmail dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: xry111 at xry111 dot site @ 2024-01-22 19:54 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=31276
Bug ID: 31276
Summary: Wrong condition for heap allocation in qsort_r
Product: glibc
Version: 2.39
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: libc
Assignee: unassigned at sourceware dot org
Reporter: xry111 at xry111 dot site
CC: drepper.fsp at gmail dot com
Target Milestone: ---
/* Align to the maximum size used by the swap optimization. */
_Alignas (uint64_t) char tmp[QSORT_STACK_SIZE];
size_t total_size = total_elems * size;
char *buf;
if (size > INDIRECT_SORT_SIZE_THRES)
total_size = 2 * total_elems * sizeof (void *) + size;
if (total_size < sizeof buf)
buf = tmp;
else
{ /* allocate buf on heap ... */ }
Here "sizeof buf" is the size of a pointer, but (obviously?) we want
QSORT_STACK_SIZE here, i.e. "sizeof tmp".
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug libc/31276] Wrong condition for heap allocation in qsort_r 2024-01-22 19:54 [Bug libc/31276] New: Wrong condition for heap allocation in qsort_r xry111 at xry111 dot site @ 2024-01-23 13:21 ` hjl.tools at gmail dot com 2024-01-26 19:30 ` gabravier at gmail dot com 2024-01-27 11:09 ` sam at gentoo dot org 2 siblings, 0 replies; 4+ messages in thread From: hjl.tools at gmail dot com @ 2024-01-23 13:21 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=31276 H.J. Lu <hjl.tools at gmail dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.39 Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> --- Fixed by https://sourceware.org/git?p=glibc.git;a=commit;h=dfa3394a605c8f6f25e4f827789bc89eca1d206c -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug libc/31276] Wrong condition for heap allocation in qsort_r 2024-01-22 19:54 [Bug libc/31276] New: Wrong condition for heap allocation in qsort_r xry111 at xry111 dot site 2024-01-23 13:21 ` [Bug libc/31276] " hjl.tools at gmail dot com @ 2024-01-26 19:30 ` gabravier at gmail dot com 2024-01-27 11:09 ` sam at gentoo dot org 2 siblings, 0 replies; 4+ messages in thread From: gabravier at gmail dot com @ 2024-01-26 19:30 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=31276 Gabriel Ravier <gabravier at gmail dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gabravier at gmail dot com -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug libc/31276] Wrong condition for heap allocation in qsort_r 2024-01-22 19:54 [Bug libc/31276] New: Wrong condition for heap allocation in qsort_r xry111 at xry111 dot site 2024-01-23 13:21 ` [Bug libc/31276] " hjl.tools at gmail dot com 2024-01-26 19:30 ` gabravier at gmail dot com @ 2024-01-27 11:09 ` sam at gentoo dot org 2 siblings, 0 replies; 4+ messages in thread From: sam at gentoo dot org @ 2024-01-27 11:09 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=31276 Sam James <sam at gentoo dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam at gentoo dot org -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-27 11:09 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-01-22 19:54 [Bug libc/31276] New: Wrong condition for heap allocation in qsort_r xry111 at xry111 dot site 2024-01-23 13:21 ` [Bug libc/31276] " hjl.tools at gmail dot com 2024-01-26 19:30 ` gabravier at gmail dot com 2024-01-27 11:09 ` sam at gentoo dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).