[Bug dynamic-link/31357] New: Incorrect $(objpfx)tst-rtld-list-diagnostics.out rule

[Bug dynamic-link/31357] New: Incorrect $(objpfx)tst-rtld-list-diagnostics.out rule

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31357

            Bug ID: 31357
           Summary: Incorrect $(objpfx)tst-rtld-list-diagnostics.out rule
           Product: glibc
           Version: 2.40
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dynamic-link
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
  Target Milestone: ---

elf/Makefile has

$(objpfx)tst-rtld-list-diagnostics.out: tst-rtld-list-diagnostics.py \
  $(..)manual/dynlink.texi $(objpfx)$(rtld-installed-name)
        $(PYTHON) tst-rtld-list-diagnostics.py \
          --manual=$(..)manual/dynlink.texi \
          "$(test-wrapper-env) $(objpfx)$(rtld-installed-name)
--list-diagnostics" \
          > $@; \
        $(evaluate-test)

Since there is no environment variable to set, $(test-wrapper-env) isn't
needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/31357] Incorrect $(objpfx)tst-rtld-list-diagnostics.out rule

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31357

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
The problem is that tst-rtld-list-diagnostics.py doesn't handle test
wrapper properly:

python3 -B tst-rtld-list-diagnostics.py \
  --manual=../manual/dynlink.texi \
  "/export/build/gnu/tools-build/glibc-apx-sde/test-sde.sh env
/export/build/gnu/tools-build/glibc-apx-sde/build-x86_64-linux/elf/ld-linux-x86-64.so.2
--list-diagnostics"

tst-rtld-list-diagnostics.py tries to skip the unnecessary env, but it
drops the test wrapper instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/31357] $(objpfx)tst-rtld-list-diagnostics.out rule doesn't work with test wrapper

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31357

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Incorrect                   |$(objpfx)tst-rtld-list-diag
                   |$(objpfx)tst-rtld-list-diag |nostics.out rule doesn't
                   |nostics.out rule            |work with test wrapper

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/31357] $(objpfx)tst-rtld-list-diagnostics.out rule doesn't work with test wrapper

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31357

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 15355
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15355&action=edit
Testing a patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/31357] $(objpfx)tst-rtld-list-diagnostics.out rule doesn't work with test wrapper

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31357

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |2.40

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed by

commit 15de3d17e1d9da5d38efb0a87a82efbc5bda732d
Author: Florian Weimer <fweimer@redhat.com>
Date:   Fri Feb 9 16:16:08 2024 +0100

    elf: Remove attempt at env handling in elf/tst-rtld-list-diagnostics.py

    Instead, let the system shell parse the whole thing and invoke the env
    command.

-- 
You are receiving this mail because:
You are on the CC list for the bug.